Repository navigation
Conversation
MapInteractiveViewerState created _isPanLeaping, _isZoomLeaping and _isRotateLeaping but never disposed them, so leak_tracker reports every map. They are disposed after the keyboard animations, because those drive the listeners that write them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gregpakes
marked this pull request as ready for review
November 1, 2026 16:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapInteractiveViewerStatecreates_isPanLeaping,_isZoomLeapingand_isRotateLeapingbut never disposes them, soleak_trackerreports them for everyFlutterMap._ckrTriggered, the otherValueNotifier<bool>in that class, is already disposed.This is the bookkeeping only: there is no user-visible behaviour change.
Why dispose is safe here. After
dispose(), the notifiers have two possible writers inmaybeLeap.listenForLeapCompletionis driven by a keyboard animation controller, so the new calls come after_disposeKeyboardAnimations(). ThecancelLeap.thencallback only runs when a key event completes the completer, and the widget gets no key events once it is gone.Tests. Two added to
map_interactive_viewer_test.dart:ValueNotifier<bool>the map creates is disposed, tracked throughFlutterMemoryAllocations. This fails without the change.The full suite and
dart analyzepass locally on Flutter 3.47.4.AI disclosure. I used Claude Code to find this, write the change and write the tests.
🤖 Generated with Claude Code