fix: LatLng is not finite exception#2208
Closed
maheshj01 wants to merge 1 commit into
Closed
Conversation
Author
|
@JaffaKetchup Any update on the review? |
Member
|
Unfortunately I'm still away and will be for a little while more. @fleaflet/maintainers is anyone else around to look into this? That would be amazing thanks. |
|
We're using it in production, it looks correct and indeed prevents the bug. |
Member
|
Thanks for this PR @maheshj01. I'll keep it in mind for a future fix, but as a quick fix, I'm going to just revert the original PR - since I'm not comfortable that this will fix ALL the possible issues that that PR introduced. Please see #2218. |
JaffaKetchup
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2199