fix: throw when LatLng is non-finite

[monsieurtanuki]

Now we throw an Exception when a LatLng is NaN - at projection time.
Doesn't look particularly good, but at least we avoid a memory leak, and anyway, who put the NaN in the first place?

The code isn't bullet proof as developers may extend Crs differently, but in most cases that should work.
And it's good enough.

[JaffaKetchup]

Sorry for not responding sooner. Would it make sense to check if either number is not finite? Then we'll protect against infinities as well.

[monsieurtanuki]

@JaffaKetchup Had to fix unrelated code too, because of parameter_assignments lint.

But the build fails because of too strict parameters.
We cannot reach a pub.dev score of 160/160, because we use Logger that only reaches 150 (doesn't officially support wasm).

[monsieurtanuki]

@JaffaKetchup I've just "fixed" the score part: we now expect the top score - 10.

[JaffaKetchup]

Annoyingly, we do support WASM. I'll write a PR to remove logger and replace with logging.

[JaffaKetchup]

#2185 is that PR. I've removed your change to the workflow. Thanks for all the other fixes, happy with those as well! We can merge this once #2185 is merged first.

[JaffaKetchup]

LGTM, thanks again :)

[monsieurtanuki]

#2185 is that PR. I've removed your change to the workflow. Thanks for all the other fixes, happy with those as well! We can merge this once #2185 is merged first.

Thank you @JaffaKetchup! For the record in the current PR I also fixed issues for score 160, beyond using logger. Feel free to find inspiration here.

[JaffaKetchup]

Thanks, yeah all fixed there. I reverted those unrelated changes here as well. Unfortunately we still don't get 160 points due to dart-lang/pana#1571 -> dart-lang/pub-dev#6785 (comment).

Should be good to merge now, thanks again!

[monsieurtanuki]

@JaffaKetchup As far as I can see, we're only using static consts, and simple methods HttpDate.format(DateTIme) and HttpDate.parse(String).
We could copy/paste the needed code. Nothing to be very proud of, but it's open source and it's somehow blocking us.

[JaffaKetchup]

Yeah, it's an option, but not ideal. I'll see where dart-lang/http#1887 goes first - probably nowhere fast though! Might have to copy it anyway...

[JaffaKetchup]

This has been reverted in #2218 as it caused un-forseen issues. Sorry, this was my fault, should've reviewed better!

#2213 introduced a specific check/fix for this case. #2199 was caused by other internal bugs, such as NaNs being produced unexpectedly. A new issue will be opened to investigate this.

[JaffaKetchup]

Sorry again! See #2219 for a full explanation and timeline.