Skip to content

New builderplayground version #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZanCorDX merged 4 commits into from
Jan 27, 2026
Merged

New builderplayground version #873

ZanCorDX merged 4 commits into from
Jan 27, 2026
+30 −9

Conversation

@ZanCorDX
Copy link
Collaborator

@ZanCorDX ZanCorDX commented Jan 27, 2026

📝 Summary

CI was using an old parched version of builderplaygound. I updated to use the latest (v0.3.1)

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@claude
Copy link
Contributor

claude bot commented Jan 27, 2026 •
edited
Loading

Claude finished @ZanCorDX's task in 1m 3s —— View job

Code Review Complete

  • Gather context and read CLAUDE.md
  • Review changed files
  • Analyze version upgrade changes
  • Post review feedback

Summary

This PR updates the builder-playground version from v0.1.3-reth-1.4.8 to v0.3.1 and updates the configuration files to match the new directory structure.

Changes Reviewed

File Change
.github/workflows/checks.yaml Updated builder-playground version and command syntax
config-playground.toml Updated paths to new playground state directory
config-playground-http-blocklist.toml Updated paths to new playground state directory

Review Feedback

Overall Assessment: Looks good to merge ✓

The changes are straightforward and appropriate for the version upgrade:

  1. Version upgrade: The playground version is updated from v0.1.3-reth-1.4.8 to v0.3.1

  2. Command syntax change: The playground command changed from:

    builder-playground &

    to:

    builder-playground start l1 --use-native-reth &

    This appears to be the new CLI syntax for v0.3.x which explicitly specifies starting an L1 network with native reth.

  3. Directory structure update: The playground state directory changed from:

    • $HOME/.playground/devnet/ → $HOME/.local/state/builder-playground/devnet/
    • data_reth → volume-el-data
    • IPC path now includes the volume-el-data subdirectory

    These path changes reflect the new playground's XDG-compliant state directory location.

  4. Minor nit: Left an inline comment about a missing trailing newline in config-playground.toml.

The changes are consistent across both config files and the workflow. No security concerns or bugs identified.

claude[bot]
claude bot reviewed Jan 27, 2026
View reviewed changes
crates/rbuilder/src/integration/test_data/config-playground.toml Outdated
blocklist_file_path = "./src/integration/test_data/blocklist.json"
root_hash_use_sparse_trie = true
root_hash_compare_sparse_trie = false
root_hash_compare_sparse_trie = false
Copy link
Contributor

@claude claude bot Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: The file is now missing a trailing newline. This is a common best practice for text files to ensure proper POSIX compliance and avoid potential issues with tools that expect newlines at EOF.

Suggested change
root_hash_compare_sparse_trie = false
root_hash_compare_sparse_trie = false

@claude
Copy link
Contributor

claude bot commented Jan 27, 2026 •
edited
Loading

Claude finished @ZanCorDX's task in 1m 0s —— View job

Code Review Complete

  • Gather context and read CLAUDE.md
  • Review changed files in detail
  • Analyze the new commit changes
  • Post review feedback

Summary

This PR updates the builder-playground version from v0.1.3-reth-1.4.8 to v0.3.1 and updates the configuration files to match the new directory structure.

Changes Reviewed

File Change
.github/workflows/checks.yaml Updated builder-playground version and command syntax
config-playground.toml Updated paths to new playground state directory
config-playground-http-blocklist.toml Updated paths to new playground state directory

Review Feedback

Overall Assessment: Ready to merge ✓

The changes are straightforward and appropriate for the version upgrade:

  1. Version upgrade: The playground version is updated from v0.1.3-reth-1.4.8 to v0.3.1

  2. Command syntax change: The playground command changed from:

    builder-playground &

    to:

    builder-playground start l1 --use-native-reth &

    This is the new CLI syntax for v0.3.x which explicitly specifies starting an L1 network with native reth.

  3. Directory structure update: The playground state directory changed from:

    • $HOME/.playground/devnet/ → $HOME/.local/state/builder-playground/devnet/
    • data_reth → volume-el-data
    • IPC path now includes the volume-el-data subdirectory

    These path changes reflect the new playground's XDG-compliant state directory location.

  4. Trailing newlines: ✅ The latest commit (7c01450 "newline") fixed the missing trailing newlines in both config files that were flagged in the previous review.

The changes are consistent across both config files and the workflow. No security concerns or bugs identified.

@claude
Copy link
Contributor

claude bot commented Jan 27, 2026 •
edited
Loading

Claude finished @ZanCorDX's task in 1m 5s —— View job

Code Review Complete

  • Gather context and read CLAUDE.md
  • Review changed files in detail
  • Analyze the latest commit
  • Post review feedback

Summary

This PR updates the builder-playground version from v0.1.3-reth-1.4.8 to v0.3.1 and updates the configuration files to match the new directory structure.

Changes Reviewed

File Change
.github/workflows/checks.yaml Updated builder-playground version, command syntax, and logs path
config-playground.toml Updated paths to new playground state directory
config-playground-http-blocklist.toml Updated paths to new playground state directory

Review Feedback

Overall Assessment: Ready to merge ✓

The changes are straightforward and appropriate for the version upgrade:

  1. Version upgrade: The playground version is updated from v0.1.3-reth-1.4.8 to v0.3.1

  2. Command syntax change: The playground command changed from:

    builder-playground &

    to:

    builder-playground start l1 --use-native-reth &

    This is the new CLI syntax for v0.3.x which explicitly specifies starting an L1 network with native reth.

  3. Directory structure update: The playground state directory changed from:

    • $HOME/.playground/devnet/ → $HOME/.local/state/builder-playground/devnet/
    • data_reth → volume-el-data
    • IPC path now includes the volume-el-data subdirectory

    These path changes reflect the new playground's XDG-compliant state directory location.

  4. Logs path fix (latest commit beb1159): The logs aggregation step was updated to use the new state directory path ($HOME/.local/state/builder-playground/devnet/logs), which was necessary for the CI failure log collection to work correctly with the new playground version.

  5. Trailing newlines: ✅ Both config files now have proper trailing newlines (fixed in commit 7c01450).

Verification

The changes are consistent across all three files:

  • Config paths match the new playground structure
  • Both toml files use the same updated paths
  • The workflow file correctly references the new state directory for logs

No security concerns, bugs, or issues identified. The PR is ready for merge.

@claude
Copy link
Contributor

claude bot commented Jan 27, 2026 •
edited
Loading

Claude finished @ZanCorDX's task in 1m 9s —— View job

Code Review Complete

  • Gather context and read CLAUDE.md
  • Review changed files in detail
  • Analyze the latest commit (wait for builderplayground)
  • Post review feedback

Summary

This PR updates the builder-playground version from v0.1.3-reth-1.4.8 to v0.3.1 and updates the configuration files to match the new directory structure.

Changes Reviewed

File Change
.github/workflows/checks.yaml Updated builder-playground version, command syntax, logs path, and added health check wait logic
config-playground.toml Updated paths to new playground state directory
config-playground-http-blocklist.toml Updated paths to new playground state directory

Review Feedback

Overall Assessment: Ready to merge ✓

The changes are well-structured and appropriate for the version upgrade:

  1. Version upgrade: The playground version is updated from v0.1.3-reth-1.4.8 to v0.3.1

  2. Command syntax change: The playground command changed from:

    builder-playground &

    to:

    builder-playground start l1 --use-native-reth &

    This is the new CLI syntax for v0.3.x which explicitly specifies starting an L1 network with native reth.

  3. Directory structure update: The playground state directory changed from:

    • $HOME/.playground/devnet/ → $HOME/.local/state/builder-playground/devnet/
    • data_reth → volume-el-data

    These path changes reflect the new playground's XDG-compliant state directory location.

  4. Health check wait logic (latest commit aa56d32): The "Run the playground" step now properly waits for the playground to be healthy before proceeding:

    • Redirects output to /tmp/playground.log
    • Polls for "All services are healthy" message with a 60-second timeout
    • On timeout, outputs the last 50 lines of logs and kills the process before failing
    • This is a good improvement over the previous approach which just started the playground in the background without waiting

  5. Minor observations on the wait logic:

    • The comment says "1 minutes timeout" (should be "1 minute") - minor typo but doesn't affect functionality
    • The logic is sound and handles both success and failure cases appropriately
    • Capturing the PID and logging it on success is helpful for debugging

  6. Config files: Both config files now have proper trailing newlines (fixed in commit 7c01450) and use the same updated paths consistently.

Verification

The changes are consistent across all three files:

  • Config paths match the new playground structure
  • Both toml files use the same updated paths
  • The workflow file correctly references the new state directory for logs

No security concerns, bugs, or critical issues identified. The PR is ready for merge.

@ZanCorDX ZanCorDX marked this pull request as ready for review January 27, 2026 17:56
@ZanCorDX ZanCorDX merged commit 0d39e91 into develop Jan 27, 2026
7 checks passed
@ZanCorDX ZanCorDX deleted the dx/update-playground branch January 27, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@metachris metachris metachris approved these changes

@dvush dvush Awaiting requested review from dvush dvush is a code owner

@sukoneck sukoneck Awaiting requested review from sukoneck sukoneck is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZanCorDX @metachris