-
Notifications
You must be signed in to change notification settings - Fork 13
(Draft) Bob L2 Image #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| echo "Running in local QEMU, using hardcoded metadata values" | ||
|
|
||
| cat <<EOF >> "$CONFIG_PATH" | ||
| CONFIG_NETWORK_ID='12345' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this hardcoded config?
|
|
||
| # Ideally, this logic should be somewhere else, but it's fine for now | ||
| chattr -i /etc/resolv.conf || true | ||
| echo "nameserver 1.1.1.1" > /etc/resolv.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we already have equivalent code somewhere in the base branch. maybe its gone now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we're setting 8.8.8.8 8.8.4.4 in base. Why does it need to be cloudflare for bob-l2? I'm also cool just switching everything to cloudflare since that's a better dns server anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilyaluk what was the purpose of these lines?
chore: fix bob-l2 image build
No description provided.