fix: Keep currentCameras balanced when componentsAtPoint is not fully iterated - #3971
Open
hadiidbouk wants to merge 1 commit into
Open
fix: Keep currentCameras balanced when componentsAtPoint is not fully iterated#3971hadiidbouk wants to merge 1 commit into
hadiidbouk wants to merge 1 commit into
Conversation
hadiidbouk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the permanent blank-screen bug in #3972.
componentsAtLocationleaks the camera onto the staticcurrentCameraslist when the caller stops iterating early, and after 4 leaks nothing renders anymore. Full details are in the issue.The fix pushes and pops the camera around each step, inside a
try/finally, so stopping early can no longer leak. Adds a regression test.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #3972