Skip to content

Fix scrolling on mouse wheel on sprite pane #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
foxnne merged 1 commit into from
Jun 5, 2026
Merged

Fix scrolling on mouse wheel on sprite pane #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/editor/panel/sprites.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ const sprite_fling_touch: fizzy.Fling.Tuning = .{
};
/// Window the touch release velocity is averaged over (s).
const sprite_fling_touch_window_s: f32 = 0.1;
/// Upper bound on the per-frame delta fed to the passive cover-flow ease.
const max_ease_dt: f32 = 1.0 / 30.0;
/// Draw an on-screen readout of the last touch fling decision (velocity / idle / coast)
/// so the touch-only momentum can be tuned on a real device. Set false to hide.
const debug_touch_fling = false;
Expand Down Expand Up @@ -258,7 +260,9 @@ pub fn draw(self: *Sprites) !void {
} else {
const diff = self.goal - self.scroll_pos;
if (@abs(diff) > 0.001) {
const dt = dvui.secondsSinceLastFrame();
// Clamp dt so a wake-from-idle frame (huge secondsSinceLastFrame) doesn't
// collapse the ease into a single-frame snap. See `max_ease_dt`.
const dt = @min(dvui.secondsSinceLastFrame(), max_ease_dt);
const t = 1.0 - @exp(-12.0 * dt);
self.scroll_pos += diff * t;
dvui.refresh(null, @src(), dvui.parentGet().data().id);
Expand Down Expand Up @@ -770,7 +774,14 @@ fn handleInput(self: *Sprites, file: anytype, mode: ScrollMode, count: usize, px
if (inside) {
e.handle(@src(), pane);
const amt = if (me.action == .wheel_x) me.action.wheel_x else me.action.wheel_y;
self.wheel_accum += amt * 0.01;
// A discrete mouse wheel advances one sprite per notch; a trackpad
// accumulates its stream of small deltas smoothly. We can't key off the
// raw magnitude: a single wheel notch is ~1.0
if (dvui.mouseType() == .mouse) {
self.wheel_accum += std.math.sign(amt);
} else {
self.wheel_accum += amt * 0.01;
}
while (@abs(self.wheel_accum) >= 1.0) {
const step: f32 = if (self.wheel_accum > 0.0) 1.0 else -1.0;
self.wheel_accum -= step;
Expand Down
Loading