Repository navigation
composer: Enter is a new line on a phone, 8-line box - #23
Open
fizzy-macos[bot] wants to merge 1 commit into
Open
fizzy-macos[bot] wants to merge 1 commit into
fizzy-macos[bot] wants to merge 1 commit into
Conversation
Part of fizzyedit/work#530 Agent-Team: macos Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In plain words
On a phone, pressing Enter in the chat's message box now starts a new line instead of sending, because a phone's Send button is what sends. On a computer Enter still sends and Shift+Enter adds a line. The box also grows taller before it starts scrolling, so longer messages stay readable while you write them.
What you will notice
On a phone or tablet build, Enter adds a line. On desktop nothing changes except the box growing to eight lines (was six) before it scrolls.
How this serves fizzy
Goal: phone typing (mobile): the same chat composes comfortably on a phone as on a desktop.
Goal
Port the composer rules from fizzy's #910 into the chat's message box (fizzyedit/work#530).
What changed and why
src/composer.zig(std-only):enter(shift, mobile)andmax_lines = 8, with unit tests, wired intoView.drawInput.build.zig: the new tests run underzig build test.How it was verified
zig fmt --check build.zig plugin.zig src: cleanzig build test: passes (includes the new composer tests; the Enter test fails without the change as the file is new)zig build(into a temporary FIZZY_PROFILE): passesNot done / follow-ups
core.form_factor), socomposer.isMobile()uses the build target (iOS/Android). A phone's web browser or a narrow desktop layout still counts as desktop; needs the SDK to expose it (the issue says no new SDK types).Segmentssplitter. Message text already goes through the markdown service, which renders fenced code, so a splitter would be dead code here.chat.sampleclient: not added (the repo has no scripted client;chat/no-sampleremoved it); separate piece.Part of fizzyedit/work#530