Skip to content

FCE-2467: Implement proper crypto polyfil#442

Merged
MiloszFilimowski merged 2 commits intomobile-sdk-2-0from
mfilimowski/fce-2467-crypro
Jan 8, 2026
Merged

FCE-2467: Implement proper crypto polyfil#442
MiloszFilimowski merged 2 commits intomobile-sdk-2-0from
mfilimowski/fce-2467-crypro

Conversation

@MiloszFilimowski
Copy link
Copy Markdown
Collaborator

Description

  • use react-native-get-random-values as getRandomValues.

Motivation and Context

  • We had a temporary implmenation.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@linear
Copy link
Copy Markdown

linear Bot commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces a temporary Math.random()-based implementation of crypto.getRandomValues with the proper react-native-get-random-values library polyfill.

  • Adds react-native-get-random-values dependency to provide secure random value generation
  • Removes the temporary crypto polyfill implementation and associated TODO comment

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
packages/mobile-client/package.json Adds react-native-get-random-values dependency
yarn.lock Updates lock file with new dependency and its transitive dependency (fast-base64-decode)
packages/mobile-client/src/webrtc-polyfill.ts Imports react-native-get-random-values and removes temporary Math.random()-based crypto implementation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MiloszFilimowski MiloszFilimowski merged commit 5eb3a95 into mobile-sdk-2-0 Jan 8, 2026
@MiloszFilimowski MiloszFilimowski deleted the mfilimowski/fce-2467-crypro branch January 8, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants