Conversation
Move the session option definition into addSessionOption so the root command can share its spelling and help text with individual commands.
Register --session on the root command and pass its value to command actions so scripts can place session selection before the command.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6358 +/- ##
=======================================
Coverage 84.12% 84.12%
=======================================
Files 356 356
Lines 38445 38445
Branches 10888 10888
=======================================
Hits 32340 32340
Misses 5676 5676
Partials 429 429 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mstange
approved these changes
Sep 25, 2026
fqueze
reviewed
Sep 25, 2026
| profiler-cli profile info --session my-analysis | ||
| profiler-cli thread select t-0 --session my-analysis | ||
|
|
||
| The --session option can also appear before the command: |
Contributor
There was a problem hiding this comment.
What's the point of adding these lines to the guide? The fact this bug was reported in the first place means some sessions tried to put the session parameter there already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
The CLI rejects
--sessionbefore the command, requiring scripts to place it after the subcommand. Register it globally so both forms work:Fixes #6357