Show allocation data in the cli - #6246
Open
fatadel wants to merge 1 commit into
Open
Conversation
The samples and functions commands only summarized sample timing, so JS and native allocation data was invisible from the cli. Add --strategy to the samples, functions and annotate commands to pick a data source per invocation, and "thread strategy" to set it for the session. Allocation sources weigh the call tree in bytes, and "thread info" lists the sources each thread has. Closes firefox-devtools#6183
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6246 +/- ##
==========================================
- Coverage 83.69% 83.65% -0.05%
==========================================
Files 348 349 +1
Lines 37433 37485 +52
Branches 10514 10531 +17
==========================================
+ Hits 31330 31358 +28
- Misses 5676 5700 +24
Partials 427 427 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
The samples and functions commands only summarized sample timing, so JS and native allocation data was invisible from the cli.
Add --strategy to the samples, functions and annotate commands to pick a data source per invocation, and "thread strategy" to set it for the session. Allocation sources weigh the call tree in bytes, and "thread info" lists the sources each thread has.
Closes #6183
Profiles to explore:
Normal · JS Allocations · Native Allocations