Skip to content

Update home page message for the other browser case#5866

Merged
fatadel merged 3 commits intofirefox-devtools:mainfrom
fatadel:refine-home-msg-5812
Mar 3, 2026
Merged

Update home page message for the other browser case#5866
fatadel merged 3 commits intofirefox-devtools:mainfrom
fatadel:refine-home-msg-5812

Conversation

@fatadel
Copy link
Contributor

@fatadel fatadel commented Feb 27, 2026

Closes #5812.

  1. Remove irrelevant comment.
  2. Clarify that Firefox for desktop is needed for profiling which should eliminate confusion on, for example, Firefox for iOS.
  3. Update download link, remove hardcoded en-US locale.

I have 1 question. Since I've update a translation without updating its key, will the localizers be informed that the master translation changed?

Before
before

After
after

1. Remove irrelevant comment.
2. Clarify that Firefox for desktop is needed for profiling which should eliminate confusion on, for example, Firefox for iOS.
3. Update download link, remove hardcoded en-US locale.
@fatadel fatadel requested review from canova and mstange February 27, 2026 17:15
@fatadel fatadel requested a review from a team as a code owner February 27, 2026 17:15
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.36%. Comparing base (850e4ff) to head (4943d1c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5866      +/-   ##
==========================================
- Coverage   85.36%   85.36%   -0.01%     
==========================================
  Files         320      320              
  Lines       31916    31918       +2     
  Branches     8780     8778       -2     
==========================================
  Hits        27246    27246              
- Misses       4239     4241       +2     
  Partials      431      431              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@flodolo
Copy link
Contributor

flodolo commented Feb 27, 2026

I have 1 question. Since I've update a translation without updating its key, will the localizers be informed that the master translation changed?

No, you always need to update the ID. See this page for more details.

Copy link
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh I liked the comments on top of the images 😂 Looks good, thanks!

At first I was thinking about mentioning Android too, but it looks like we already do in the second paragraph. So it looks good to me.

@fatadel fatadel merged commit b79d3b0 into firefox-devtools:main Mar 3, 2026
21 of 22 checks passed
@fatadel fatadel deleted the refine-home-msg-5812 branch March 3, 2026 07:00
@canova canova mentioned this pull request Mar 3, 2026
canova added a commit that referenced this pull request Mar 3, 2026
Changes:

[fatadel] Fix crash when nativeSymbol index is out of bounds in assembly
view (#5850)
[depfu[bot]] Update all Yarn dependencies (2026-02-25) (#5859)
[Nazım Can Altınova] Fix the color of dark mode back arrow svg (#5863)
[fatadel] Force canvas redraw when system theme changes (#5861)
[Nazım Can Altınova] Fix unhandled promise rejection in
setupInitialUrlState (#5864)
[fatadel] Persist selected marker in URL and show sticky tooltip on load
(#5847)
[Markus Stange] Implement the "collapse resource" transform with the
help of the "collapse direct recursion" transform. (#5824)
[Markus Stange] Bump rollup from 2.79.2 to 2.80.0 (#5868)
[Markus Stange] Remove async attribute from module script tag. (#5870)
[Nazım Can Altınova] Update the docsify package that's used in the user
documentation (#5872)
[Markus Stange] Share stackTable, frameTable, funcTable, resourceTable
and nativeSymbols between threads (#5482)
[Nazım Can Altınova] Escape CSS URLs that are coming from profiles
(#5874)
[fatadel] Update home page message for the other browser case (#5866)
[fatadel] Add support for ternaries in marker labels (#5857)
[Markus Stange] Reduce allocations for getStackLineInfo +
getStackAddressInfo (#5761)

And special thanks to our localizers:

de: Ger
fy-NL: Fjoerfoks
it: Francesco Lodolo [:flod]
nl: Fjoerfoks
ru: berry
ru: Valery Ledovskoy
zh-TW: Pin-guang Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refine home page message on Firefox for iOS

3 participants