feat(observability): MetricsRecorder port + NoOp adapter (v26.06.72)#99
Merged
Conversation
…er + bump v26.06.72 Audit follow-up (observability had no port abstraction). Added MetricsRecorder Protocol (the counter/histogram/gauge recording contract) in observability/ports.py + NoOpMetricsRecorder (inert handles) for tests / metrics-disabled deployments. MetricsRegistry now nominally implements the port (Prometheus adapter). Tracing exporters were already config-swappable (otlp|console|none), so a full multi-backend metrics abstraction would be YAGNI — kept this a lightweight port + one real alt adapter. Tests: tests/observability/test_metrics_recorder_port.py (2). Gates: mypy --strict (638), ruff + format, full suite green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit follow-up (#2 — observability had no port abstraction). Adds a
MetricsRecorderprotocol port (the counter/histogram/gauge recording contract) so instrumentation isn't hard-coupled to Prometheus, plusNoOpMetricsRecorder— a dependency-free adapter for tests and metrics-disabled deployments (every op is an inert no-op handle).MetricsRegistrynow nominally implements the port (the Prometheus adapter).Note: tracing exporters were already config-swappable (
pyfly.observability.tracing.exporter=otlp|console|none), so a full multi-backend metrics abstraction would be YAGNI — this stays a lightweight port + one real alternative adapter, not a speculative refactor. Tests (2). Gates: mypy --strict (638), ruff+format, full suite green.