test(adapters): behavior coverage for external IDP/ECM/notification adapters (v26.06.71)#98
Merged
Merged
Conversation
…bump v26.06.71 Closes the audit gap (wiring/isinstance-only coverage). Added behavior tests (fake httpx / boto3 clients, no network/Docker) asserting request shape + response parsing for: notifications resend/twilio/firebase, ecm docusign/adobe_sign/logalty + aws_s3 (injected boto3 client), idp keycloak. Each covers happy path + error/non-2xx mapping + edge cases (sender precedence, attachment encoding, multi-token partial success, status mapping). Adapters unchanged. Written + self-verified by a parallel workflow (one agent per adapter). Gates: mypy --strict (637), ruff + format, full suite green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the audit gap where external adapters were only wiring/
isinstance-tested. 42 mocked-I/O behavior tests (no network/Docker) asserting both the outbound request shape (URL/verb/payload/auth headers) and response→domain parsing:Each covers happy-path + error/non-2xx mapping + edge cases (sender precedence, attachment base64, multi-token partial success, status enum mapping). Adapter source unchanged. Written + self-verified by a parallel workflow (one agent per adapter, each ran its own tests green). Gates: mypy --strict (637), ruff+format, full suite green.