Fix Alexandria terms acceptance version flag - #239
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terms acceptance command used --version, which the root CLI consumed as its own version flag, exiting successfully without submitting a request. Rename it to --terms-version and keep the API payload field as version. Update the error guidance, README, and focused tests.
Validation: TypeScript build and 26 focused tests pass. Ran the actual built CLI against a local mock HTTP server: missing --confirm exits 1 without a request; explicit confirmation sends exactly one POST with the expected provider, version, digest, and confirmed fields and exits 0. No live terms acceptance performed.
The separate live terms catalog 403 remains a backend access issue; this PR fixes the CLI flag collision.
Summary by cubic
Fixes the
alexandria terms acceptcommand's--versionflag colliding with the root CLI's version flag, which made the command exit successfully without submitting a request. The flag is renamed to--terms-version; the API payload field remainsversion.Notes
--terms-version.Written for commit c2774e4. Summary will update on new commits.