Skip to content

Fix Alexandria terms acceptance version flag - #239

Merged
developersdigest merged 1 commit into
mainfrom
fix/alexandria-terms-version
Sep 17, 2026
Merged

developersdigest merged 1 commit into
mainfrom
fix/alexandria-terms-version

Conversation

@developersdigest

@developersdigest developersdigest commented Sep 17, 2026

Copy link
Copy Markdown
Member

The terms acceptance command used --version, which the root CLI consumed as its own version flag, exiting successfully without submitting a request. Rename it to --terms-version and keep the API payload field as version. Update the error guidance, README, and focused tests.

Validation: TypeScript build and 26 focused tests pass. Ran the actual built CLI against a local mock HTTP server: missing --confirm exits 1 without a request; explicit confirmation sends exactly one POST with the expected provider, version, digest, and confirmed fields and exits 0. No live terms acceptance performed.

The separate live terms catalog 403 remains a backend access issue; this PR fixes the CLI flag collision.


Summary by cubic

Fixes the alexandria terms accept command's --version flag colliding with the root CLI's version flag, which made the command exit successfully without submitting a request. The flag is renamed to --terms-version; the API payload field remains version.

Notes

  • Updated error guidance, README, and focused tests to use --terms-version.
  • No live terms acceptance performed; the separate live terms catalog 403 remains a backend access issue.

Written for commit c2774e4. Summary will update on new commits.

Review in cubic

@developersdigest
developersdigest merged commit a3465da into main Sep 17, 2026
8 checks passed
@developersdigest
developersdigest deleted the fix/alexandria-terms-version branch September 17, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant