Skip to content

Auto-update dependencies. - #2819

Merged
thatfiredev merged 3 commits into
masterfrom
dpebot-repositorygardener
Jul 28, 2026
Merged

Auto-update dependencies.#2819
thatfiredev merged 3 commits into
masterfrom
dpebot-repositorygardener

Conversation

@dpebot

@dpebot dpebot commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Brought to you by your friendly Repository Gardener.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Android Gradle Plugin (AGP) to version 9.3.0 and Kotlin to 2.4.10 in the version catalog, and bumps the Android Lint dependencies to 32.3.0. The reviewer recommends migrating these hardcoded Lint dependencies, as well as the JUnit dependency, to the Gradle Version Catalog (gradle/libs.versions.toml) to establish a single source of truth and avoid version drift.

Comment thread internal/lint/build.gradle.kts Outdated
Comment on lines +12 to +14
compileOnly("com.android.tools.lint:lint-api:32.3.0")
testImplementation("com.android.tools.lint:lint:32.3.0")
testImplementation("com.android.tools.lint:lint-tests:32.3.0")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain a single source of truth for all dependencies and avoid version drift, these Android Lint dependencies should be defined in the Gradle Version Catalog (gradle/libs.versions.toml) instead of being hardcoded here.\n\nYou can add the following to gradle/libs.versions.toml:\n\ntoml\n[versions]\nandroidLint = "32.3.0"\n\n[libraries]\nandroid-tools-lint-api = { module = "com.android.tools.lint:lint-api", version.ref = "androidLint" }\nandroid-tools-lint = { module = "com.android.tools.lint:lint", version.ref = "androidLint" }\nandroid-tools-lint-tests = { module = "com.android.tools.lint:lint-tests", version.ref = "androidLint" }\n\n\nAdditionally, since junit is already defined in the version catalog, you can also migrate testImplementation("junit:junit:4.13.2") to testImplementation(libs.junit).

    compileOnly(libs.android.tools.lint.api)
    testImplementation(libs.android.tools.lint)
    testImplementation(libs.android.tools.lint.tests)

@dpebot
dpebot force-pushed the dpebot-repositorygardener branch from 86d2e1a to e2a087d Compare July 15, 2026 22:12
@wiz-9635d3485b

wiz-9635d3485b Bot commented Jul 15, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities 2 High 7 Medium 4 Low
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings -
Software Management Finding Software Management Findings -
Total 2 High 7 Medium 4 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio.

@dpebot
dpebot force-pushed the dpebot-repositorygardener branch 4 times, most recently from 06df7b3 to ad222ef Compare July 20, 2026 22:14
Comment thread internal/lint/build.gradle.kts Outdated
@dpebot
dpebot force-pushed the dpebot-repositorygardener branch 6 times, most recently from ec14be6 to 1d2f3c1 Compare July 26, 2026 22:11
Comment thread gradle/libs.versions.toml
Comment thread gradle/libs.versions.toml Outdated
@thatfiredev

thatfiredev commented Jul 27, 2026

Copy link
Copy Markdown
Member

AGP 9.3.x seems to have a bug with custom lint. We should hold that upgrade for now. See b/522845800

@dpebot
dpebot force-pushed the dpebot-repositorygardener branch from 88105b5 to 531b0b3 Compare July 27, 2026 22:12
@thatfiredev
thatfiredev merged commit 2d9538d into master Jul 28, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants