Skip to content

fix(messaging,ios): return NO from scene willConnectToSession - #18733

Merged
SelaseKay merged 1 commit into
mainfrom
fix/issue-18731
Sep 29, 2026
Merged

SelaseKay merged 1 commit into
mainfrom
fix/issue-18731

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

FLTFirebaseMessagingPlugin implemented scene:willConnectToSession:options: as void, while FlutterSceneLifeCycleDelegate declares it as BOOL. Flutter matches the selector by name and reads the return value. YES means the plugin consumed the connection, which skips cold-start deep link delivery and passes nil options to later plugins.

The method only copies notificationResponse into the plugin's initial-message state. It now returns BOOL and always returns NO, so that notification is still recorded and Flutter continues to deliver the connection.

Related Issues

Fixes #18731

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Flutter reads this callback as BOOL. A void method leaves that value undefined, so a cold-start connection can be treated as handled and its deep links dropped.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@SelaseKay
SelaseKay merged commit 056c264 into main Sep 29, 2026
38 checks passed
@SelaseKay
SelaseKay deleted the fix/issue-18731 branch September 29, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants