fix(messaging,ios): return NO from scene willConnectToSession - #18733
Conversation
Flutter reads this callback as BOOL. A void method leaves that value undefined, so a cold-start connection can be treated as handled and its deep links dropped.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Description
FLTFirebaseMessagingPluginimplementedscene:willConnectToSession:options:asvoid, whileFlutterSceneLifeCycleDelegatedeclares it asBOOL. Flutter matches the selector by name and reads the return value.YESmeans the plugin consumed the connection, which skips cold-start deep link delivery and passesniloptions to later plugins.The method only copies
notificationResponseinto the plugin's initial-message state. It now returnsBOOLand always returnsNO, so that notification is still recorded and Flutter continues to deliver the connection.Related Issues
Fixes #18731
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?