Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/e2e_tests_firestore.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ jobs:
package-path: 'packages/cloud_firestore/cloud_firestore'
package-scope: 'cloud_firestore*'
wasm: true
# Diagnostic pin: check whether the dart2wasm TFA startAfter failure is 3.47-only.
flutter-version: '3.44.0'
drive-timeout: '300'
max-attempts: '2'
native-config-args: '--firestore-native'
Expand Down
7 changes: 7 additions & 0 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ analyzer:
included_file_warning: ignore
exclude:
- packages/**/example/lib/generated_plugin_registrant.dart
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
Comment thread
SelaseKay marked this conversation as resolved.

linter:
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# in the LICENSE file.

analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: ../../../../analysis_options.yaml
linter:
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ analyzer:
# from analyze so analyze-ci passes.
exclude:
- integration_test/**
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**

linter:
# The lint rules applied to this project can be customized in the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -803,21 +803,17 @@ void runPipelineExpressionsTests() {
]);
});

test(
'arraySum addFields succeeds on Android',
() async {
final snapshot = await firestore
.pipeline()
.collection('pipeline-e2e')
.where(Expression.field('test').equalValue('expressions'))
.addFields(Expression.array([1, 2, 3]).arraySum().as('x'))
.limit(1)
.execute();
expectResultCount(snapshot, 1);
expect(snapshot.result[0].data()!['x'], 6);
},
skip: defaultTargetPlatform != TargetPlatform.android,
);
test('arraySum addFields succeeds on Android', () async {
final snapshot = await firestore
.pipeline()
.collection('pipeline-e2e')
.where(Expression.field('test').equalValue('expressions'))
.addFields(Expression.array([1, 2, 3]).arraySum().as('x'))
.limit(1)
.execute();
expectResultCount(snapshot, 1);
expect(snapshot.result[0].data()!['x'], 6);
}, skip: defaultTargetPlatform != TargetPlatform.android);

test(
'unsupported expression returns parse-error with informative message',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# in the LICENSE file.

analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: ../../../../analysis_options.yaml

linter:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# in the LICENSE file.

analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: ../../../../analysis_options.yaml
linter:
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# in the LICENSE file.

analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: ../../../../analysis_options.yaml
linter:
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ class MethodChannelFirebaseAnalytics extends FirebaseAnalyticsPlatform {
bool? securityStorageConsentGranted,
}) async {
try {
return _api.setConsent(<String, bool?>{
return await _api.setConsent(<String, bool?>{
if (adStorageConsentGranted != null)
'adStorageConsentGranted': adStorageConsentGranted,
if (analyticsStorageConsentGranted != null)
Expand All @@ -106,7 +106,7 @@ class MethodChannelFirebaseAnalytics extends FirebaseAnalyticsPlatform {
Map<String, Object?>? defaultParameters,
) async {
try {
return _api.setDefaultEventParameters(defaultParameters);
return await _api.setDefaultEventParameters(defaultParameters);
} catch (e, s) {
convertPlatformException(e, s);
}
Expand Down Expand Up @@ -168,7 +168,7 @@ class MethodChannelFirebaseAnalytics extends FirebaseAnalyticsPlatform {
Future<void> setSessionTimeoutDuration(Duration timeout) async {
try {
if (!kIsWeb && defaultTargetPlatform == TargetPlatform.android) {
return _api.setSessionTimeoutDuration(timeout.inMilliseconds);
return await _api.setSessionTimeoutDuration(timeout.inMilliseconds);
}
} catch (e, s) {
convertPlatformException(e, s);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# in the LICENSE file.

analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: ../../../../analysis_options.yaml
linter:
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@
# packages, and plugins designed to encourage good coding practices.
include: package:flutter_lints/flutter.yaml

analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**

linter:
# The lint rules applied to this project can be customized in the
# section below to disable rules from the `package:flutter_lints/flutter.yaml`
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: package:flutter_lints/flutter.yaml

# Additional information about this file can be found at
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: package:flutter_lints/flutter.yaml

# Additional information about this file can be found at
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: ../../../../analysis_options.yaml

linter:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# in the LICENSE file.

analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: ../../../../analysis_options.yaml
linter:
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# in the LICENSE file.

analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: ../../../../analysis_options.yaml

linter:
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: package:flutter_lints/flutter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ include: package:flutter_lints/flutter.yaml
analyzer:
exclude:
- lib/generated/**
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
linter:
# The lint rules applied to this project can be customized in the
# section below to disable rules from the `package:flutter_lints/flutter.yaml`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# in the LICENSE file.

analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: ../../../analysis_options.yaml
linter:
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# in the LICENSE file.

analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: ../../../../analysis_options.yaml
linter:
rules:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: package:flutter_lints/flutter.yaml

# Additional information about this file can be found at
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# in the LICENSE file.

analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: ../../../../analysis_options.yaml
linter:
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ include: ../../../../analysis_options.yaml
analyzer:
errors:
avoid_print: ignore
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**

linter:
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@
# packages, and plugins designed to encourage good coding practices.
include: package:flutter_lints/flutter.yaml

analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**

linter:
# The lint rules applied to this project can be customized in the
# section below to disable rules from the `package:flutter_lints/flutter.yaml`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# in the LICENSE file.

analyzer:
exclude:
- build/**
- android/**
- ios/**
- web/**
- windows/**
- macos/**
- linux/**
include: ../../../../analysis_options.yaml
linter:
rules:
Expand Down
Loading
Loading