Skip to content

refactor(fdc): Support for entityId path extensions and hardening#17988

Merged
aashishpatil-g merged 10 commits intomainfrom
ap/entityIdPaths
Feb 27, 2026
Merged

refactor(fdc): Support for entityId path extensions and hardening#17988
aashishpatil-g merged 10 commits intomainfrom
ap/entityIdPaths

Conversation

@aashishpatil-g
Copy link
Contributor

@aashishpatil-g aashishpatil-g commented Jan 30, 2026 •
edited
Loading

Description

  • Support for reading entity ids from paths in response extension
  • Hardening SQLite to use transactions for edits
  • Setup schema versioning to handle future schema updates.
  • Handle edge cases - multi-dimensional arrays, mixed type arrays, scalar arrays

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 30, 2026

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@aashishpatil-g aashishpatil-g changed the title WIP - Support for path extensions refactor(fdc): Support for entityId path extensions and hardening Feb 10, 2026
@aashishpatil-g
Copy link
Contributor Author

aashishpatil-g commented Feb 10, 2026

/gemini review

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 10, 2026

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@aashishpatil-g aashishpatil-g mentioned this pull request Feb 10, 2026
Merged
@aashishpatil-g
Copy link
Contributor Author

aashishpatil-g commented Feb 10, 2026

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 10, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant improvements to the caching mechanism, primarily by adding support for entity ID path extensions and hardening SQLite operations with transactions. The refactoring of cache-related methods (saveResultTree to setResultTree, getEntityDataObject to getEntityData, saveEntityDataObject to updateEntityData) provides a clearer API. The introduction of DataConnectPath, PathMetadata, PathMetadataResponse, and ExtensionResponse classes is crucial for handling entity IDs from GraphQL response extensions, allowing for more precise cache normalization. Schema versioning and transactional operations in SQLite3CacheProvider enhance data integrity and future extensibility. The removal of maxSizeBytes from CacheSettings and manageCacheSize from CacheProvider indicates a shift in cache size management, which should be noted. Overall, these changes improve the robustness, functionality, and maintainability of the caching layer.

Base automatically changed from ap/coreSdkCacheV1 to main February 11, 2026 20:30
@russellwheatley
Copy link
Member

russellwheatley commented Feb 20, 2026

@aashishpatil-g - Just letting you know there's some merge conflicts to be resolved and the format CI failed on this PR 🙏

@aashishpatil-g
SQLite implementation
56a37e3 
# Conflicts:
#	packages/firebase_data_connect/firebase_data_connect/pubspec.yaml

# Conflicts:
#	packages/firebase_data_connect/firebase_data_connect/pubspec.yaml

# Conflicts:
#	packages/firebase_data_connect/firebase_data_connect/lib/firebase_data_connect.dart
#	packages/firebase_data_connect/firebase_data_connect/lib/src/cache/cache_data_types.dart
#	packages/firebase_data_connect/firebase_data_connect/lib/src/cache/cache_manager.dart
#	packages/firebase_data_connect/firebase_data_connect/lib/src/cache/in_memory_cache_provider.dart
#	packages/firebase_data_connect/firebase_data_connect/lib/src/cache/result_tree_processor.dart
#	packages/firebase_data_connect/firebase_data_connect/lib/src/cache/sqlite_cache_provider.dart
#	packages/firebase_data_connect/firebase_data_connect/lib/src/common/common_library.dart
#	packages/firebase_data_connect/firebase_data_connect/lib/src/core/ref.dart
#	packages/firebase_data_connect/firebase_data_connect/lib/src/firebase_data_connect.dart
#	packages/firebase_data_connect/firebase_data_connect/pubspec.yaml
#	packages/firebase_data_connect/firebase_data_connect/test/src/cache/cache_manager_test.dart
#	packages/firebase_data_connect/firebase_data_connect/test/src/cache/cache_manager_test.mocks.dart
#	packages/firebase_data_connect/firebase_data_connect/test/src/cache/result_tree_processor_test.dart
#	packages/firebase_data_connect/firebase_data_connect/test/src/core/ref_test.dart
#	packages/firebase_data_connect/firebase_data_connect/test/src/firebase_data_connect_test.mocks.dart
#	packages/firebase_data_connect/firebase_data_connect/test/src/network/rest_transport_test.mocks.dart
@aashishpatil-g
Support for path extensions
c07d2d6
@aashishpatil-g
Handle edge cases, improve sqlite caching, adjust names to match Swift
9de2f26
@aashishpatil-g
Formatting and Fix compile error
18bce20
@aashishpatil-g
Fix analyze issues
cf69095
@aashishpatil-g
Maneesh feedback: Remove dead code
2d582af
@aashishpatil-g
addressed Gemini feedback
af7396e
@aashishpatil-g
Copy link
Contributor Author

aashishpatil-g commented Feb 21, 2026

@russellwheatley - thanks!

The merge conflicts and the formatting errrors have been fixed now.

Some of the other git e2e tests are failing but its not the data connect package.

Lyokone
Lyokone approved these changes Feb 24, 2026
View reviewed changes
@aashishpatil-g
Copy link
Contributor Author

aashishpatil-g commented Feb 27, 2026

Formatting failures are not in Data Connect package.

@aashishpatil-g aashishpatil-g merged commit fed585f into main Feb 27, 2026
26 of 31 checks passed
@aashishpatil-g aashishpatil-g deleted the ap/entityIdPaths branch February 27, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

@Lyokone Lyokone Lyokone approved these changes

@russellwheatley russellwheatley russellwheatley approved these changes

@SelaseKay SelaseKay SelaseKay approved these changes

@maneesht maneesht Awaiting requested review from maneesht

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aashishpatil-g @russellwheatley @cynthiajoan @Lyokone @SelaseKay