Skip to content

Conversation

@AustinBenoit
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Fix: fix the 32 bit windows test as the analytics dll isn't 32 bit


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Run the windows x86 test suite.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@AustinBenoit AustinBenoit added the skip-release-notes Skip release notes check label Jan 9, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AustinBenoit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug affecting the Analytics integration test suite on 32-bit Windows. The core issue stemmed from the Analytics DLL not supporting 32-bit environments, leading to test failures. To rectify this, a new SKIP_TEST_ON_WINDOWS_X86 macro has been introduced, allowing specific tests, such as TestSetLogCallback, to be conditionally bypassed when running on 32-bit Windows. This ensures the test suite can execute successfully across different Windows architectures without encountering failures due to platform-specific incompatibilities.

Highlights

  • Bug Fix for 32-bit Windows Tests: Addresses an issue where an Analytics integration test failed on 32-bit Windows due to the Analytics DLL not being compatible with 32-bit architectures.
  • Introduction of SKIP_TEST_ON_WINDOWS_X86 Macro: A new preprocessor macro is added to firebase_test_framework.h to conditionally skip tests specifically on 32-bit Windows platforms.
  • Conditional Test Skipping: The TestSetLogCallback in integration_test.cc now utilizes the SKIP_TEST_ON_WINDOWS_X86 macro to prevent its execution on incompatible 32-bit Windows environments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@AustinBenoit AustinBenoit added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Jan 9, 2026
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Jan 9, 2026
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

❌  Integration test FAILED

Requested by @AustinBenoit on commit 576f895
Last updated: Fri Jan 9 14:07 PST 2026
View integration test log & download artifacts

Failures Configs
app_check [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/4 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
auth [TEST] [FAILURE] [Windows] [1/2 ssl_lib: x86] [boringssl]
(1 failed tests)  FirebaseAuthTest.TestSignInWithBadEmailFails
firestore
(4 items)[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
[TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/4 android_device: emulator_ftl_latest]
(1 failed tests)  TaskTest.IsCompleteShouldReturnTrueForCanceledTask
[TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/4 android_device: emulator_ftl_target]
(1 failed tests)  SmokeTest.TestWillFireValueEventsForEmptyCollections
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/4 android_device: emulator_ftl_latest]
(2 failed tests)  AggregateCountTest.TestQueriesCanUseNotInFiltersWithDocIds
  QueryTest.TestWillNotGetMetadataOnlyUpdates
installations [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/4 android_device: emulator_ftl_latest]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new macro, SKIP_TEST_ON_WINDOWS_X86, to skip tests on 32-bit Windows environments, and applies it to a failing analytics integration test. The implementation is correct. My feedback focuses on improving the clarity and maintainability of the new macro by suggesting a more accurate name, SKIP_TEST_ON_WINDOWS_32BIT, since it applies to all 32-bit Windows architectures, not just x86.

AustinBenoit and others added 3 commits January 9, 2026 15:11
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jan 9, 2026
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant