Skip to content

Updating Github code to make it compatible for Google 3 importing. - #8538

Open
eldhosembabu wants to merge 3 commits into
mainfrom
emb/fcm-to-g3-compatible
Open

Updating Github code to make it compatible for Google 3 importing.#8538
eldhosembabu wants to merge 3 commits into
mainfrom
emb/fcm-to-g3-compatible

Conversation

@eldhosembabu

@eldhosembabu eldhosembabu commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Updating Github code to make it compatible for Google 3 importing.

  • Updated TopicSubscriptionClient to expose HttpConnectionFactory for Hermetic tests in G3
  • Updated TopicSubscriptionClientTests to avoid mocking on InputStream since its not supported inside G3
  • Updated DisplayNotificationTests SDK version.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

gsakakihara
gsakakihara previously approved these changes Aug 18, 2026

@gsakakihara gsakakihara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised it didn't complain, but you may also need to update the changelog.


/** A client for complying with the FCM topic subscription and unsubscription. */
class TopicSubscriptionClient {
@VisibleForTesting(otherwise = VisibleForTesting.PACKAGE_PRIVATE)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may need to hide this so that it doesn't show up in the public API.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean by using @hide ?

@eldhosembabu

Copy link
Copy Markdown
Contributor Author

I'm surprised it didn't complain, but you may also need to update the changelog.

Thats because I added no-changelog label to the PR. But actually there is no behavioral/functional changes happening in this PR. So do we need to add something there in Changelog file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants