feat(firestore): Add ifNull and coalesce expressions#7976
feat(firestore): Add ifNull and coalesce expressions#7976
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for ifNull and coalesce pipeline expressions in Firestore. The changes include updates to the public API, implementation of these expressions as both static and instance methods in the Expression class, and the addition of integration tests to verify their behavior. A minor typo was identified in the documentation for one of the ifNull overloads.
firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/expressions.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
A minor version bump in the gradle properties file may be required to fix the Metalava SemVer Check error. But maybe merging the latest changes from the main can solve this if someone already did that. |
Ported from firebase/firebase-js-sdk#9753