Skip to content

feat(firestore): Add ifNull and coalesce expressions#7976

Open
milaGGL wants to merge 8 commits intomainfrom
mila/ifnull-coalesce
Open

feat(firestore): Add ifNull and coalesce expressions#7976
milaGGL wants to merge 8 commits intomainfrom
mila/ifnull-coalesce

Conversation

@milaGGL
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL commented Mar 26, 2026

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@milaGGL
Copy link
Copy Markdown
Contributor Author

milaGGL commented Mar 27, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for ifNull and coalesce pipeline expressions in Firestore. The changes include updates to the public API, implementation of these expressions as both static and instance methods in the Expression class, and the addition of integration tests to verify their behavior. A minor typo was identified in the documentation for one of the ifNull overloads.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@yvonnep165
Copy link
Copy Markdown
Contributor

yvonnep165 commented Mar 27, 2026

A minor version bump in the gradle properties file may be required to fix the Metalava SemVer Check error. But maybe merging the latest changes from the main can solve this if someone already did that.

Copy link
Copy Markdown
Contributor

@yvonnep165 yvonnep165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants