chore: Optimize GitHub Actions and release workflows#1207
Open
lahirumaramba wants to merge 3 commits into
Open
chore: Optimize GitHub Actions and release workflows#1207lahirumaramba wants to merge 3 commits into
lahirumaramba wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the CI/CD workflow by removing the GPG passphrase from the Maven settings, switching to -Dmaven.test.skip=true, and replacing the Maven-based version extraction with a shell command. It also removes several git fetch operations. Reviewers identified that removing the passphrase from settings without passing it as a property to the Maven command will break artifact signing. Additionally, the new grep/sed method for version extraction is considered fragile, and a more robust Python-based XML parsing approach is suggested.
…ython XML parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/checkoutandactions/setup-javaacrossrelease.yml,ci.yml, andnightly.yml. This resolves Node.js 20 deprecation warnings and ensures compatibility with Node.js 24+ runners.cache: 'maven'toactions/setup-javaacross all workflows. This caches precisely~/.m2/repository, eliminating repetitive 100MB+ downloads from Maven Central and speeding up matrix CI builds.fetch-depth: 0andfetch-tags: trueon the publish checkout step inrelease.yml, removing the need for redundant secondarygit fetchcommands inpublish_preflight_check.sh.<gpg.passphrase>property fromsettings.xmland updatedrelease.ymlto passMAVEN_GPG_PASSPHRASEsecurely in the runner environment.-DskipTestswith-Dmaven.test.skip=trueinpublish_artifacts.shto completely bypass test compilation and dependency resolution during release artifact deployment.mvn help:evaluatecommand inpublish_preflight_check.shwith a lightweight Python XML parser, making extraction resilient to XML structure changes while reducing execution time from ~12 seconds to milliseconds.