Skip to content

refactor(BIG): renamed dart_firebase_admin to firebase_admin_sdk#217

Merged
demolaf merged 3 commits intomainfrom
the_rename
Apr 13, 2026
Merged

refactor(BIG): renamed dart_firebase_admin to firebase_admin_sdk#217
demolaf merged 3 commits intomainfrom
the_rename

Conversation

@kevmoo
Copy link
Copy Markdown
Collaborator

@kevmoo kevmoo commented Apr 10, 2026

Fixes #209

Added notes about the history of the package
Updated links to Invertase bits that needed to be cleanedup.
Refactored the changelogs
Updated the docs

Fixes #209

Added notes about the history of the package
Updated links to Invertase bits that needed to be cleanedup.
Refactored the changelogs
Updated the docs
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the package from dart_firebase_admin to firebase_admin_sdk, involving extensive updates to documentation, directory structures, and import statements across the repository. The review feedback identifies that the updated CHANGELOG.md is missing the release notes for version 0.5.0 and points out an incorrect file path in a comment within the functions example.

Comment thread packages/firebase_admin_sdk/CHANGELOG.md
Comment thread packages/firebase_admin_sdk/example/lib/functions_example.dart
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

Coverage Report

✅ Coverage 74.66% meets 40% threshold

Total Coverage: 74.66%
Lines Covered: 5050/6764

Package Breakdown

Package Coverage
firebase_admin_sdk 72.62%
google_cloud_firestore 76.99%

Minimum threshold: 40%

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevmoo we won't need the CHANGELOG anymore?

Copy link
Copy Markdown
Member

@demolaf demolaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a broken symlink for README.md in the root of the project — it still points to packages/dart_firebase_admin/README.md instead of packages/firebase_admin_sdk/README.md.

@demolaf
Copy link
Copy Markdown
Member

demolaf commented Apr 13, 2026

@kevmoo I've opened a PR #218 to fix the symlink issue and also a guide on how to use authentication via OAuth 2.0 refresh token to match the firebase docs https://firebase.google.com/docs/admin/setup.

@demolaf demolaf merged commit 966b300 into main Apr 13, 2026
13 checks passed
@demolaf demolaf deleted the the_rename branch April 13, 2026 14:12
@kevmoo
Copy link
Copy Markdown
Collaborator Author

kevmoo commented Apr 13, 2026

Follow-up here: firebase/firebase-functions-dart#123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finalize package name dart_firebase_admin

3 participants