Conversation
firebase-admin and firebase-functions. Changed as part of testing the workflow to flip dependencies to peer during release.
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves firebase-admin and firebase-functions from devDependencies and peerDependencies to direct dependencies in kits/firestore-bigquery-export. However, using the pre-release version ^7.3.3-rc.3 for firebase-functions prevents proper deduplication, leading to a duplicate nested installation of version 7.3.2 under @firebaseextensions/firestore-bigquery-change-tracker. Since firebase-functions relies on global state, this duplication can cause runtime initialization or deployment failures. It is recommended to use a stable version of firebase-functions to allow proper deduplication.
Comment on lines
+609
to
+611
| "node_modules/@firebaseextensions/firestore-bigquery-change-tracker/node_modules/firebase-functions": { | ||
| "version": "7.3.2", | ||
| "resolved": "https://registry.npmjs.org/firebase-functions/-/firebase-functions-7.3.2.tgz", |
Contributor
There was a problem hiding this comment.
⚠️ Duplicate firebase-functions Versions in Dependency Tree\n\nHaving multiple versions of firebase-functions (root at 7.3.3-rc.3 and nested at 7.3.2 under @firebaseextensions/firestore-bigquery-change-tracker) can lead to severe runtime issues. firebase-functions relies on global/singleton state for trigger registration and configuration; having duplicate instances of the module at runtime often causes silent deployment failures or initialization crashes (e.g., duplicate app initialization errors).\n\n#### Why this happens:\nUnder standard semver rules, the pre-release version 7.3.3-rc.3 does not satisfy the stable range ^7.3.0 required by @firebaseextensions/firestore-bigquery-change-tracker. As a result, npm resolves and installs a nested stable version (7.3.2), bypassing the deduplication process.\n\n#### Recommendation:\nConsider using a stable version of firebase-functions (e.g., ^7.3.2) in package.json to allow proper deduplication, or ensure that the override strictly forces a single version without causing nested duplication.
wandamora
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed as part of testing the workflow to flip dependencies to peer
during release.