Skip to content

chore(firestore-bigquery-export): Restore kit dependencies for firebase-admin and firebase-functions. - #3191

Open
ajperel wants to merge 1 commit into
kitsfrom
ajp/revert-firestore-bigquery-deps
Open

ajperel wants to merge 1 commit into
kitsfrom
ajp/revert-firestore-bigquery-deps

Conversation

@ajperel

@ajperel ajperel commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Changed as part of testing the workflow to flip dependencies to peer
during release.

firebase-admin and firebase-functions.

Changed as part of testing the workflow to flip dependencies to peer
during release.
@ajperel
ajperel requested a review from a team as a code owner September 12, 2026 22:09

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request moves firebase-admin and firebase-functions from devDependencies and peerDependencies to direct dependencies in kits/firestore-bigquery-export. However, using the pre-release version ^7.3.3-rc.3 for firebase-functions prevents proper deduplication, leading to a duplicate nested installation of version 7.3.2 under @firebaseextensions/firestore-bigquery-change-tracker. Since firebase-functions relies on global state, this duplication can cause runtime initialization or deployment failures. It is recommended to use a stable version of firebase-functions to allow proper deduplication.

Comment on lines +609 to +611
"node_modules/@firebaseextensions/firestore-bigquery-change-tracker/node_modules/firebase-functions": {
"version": "7.3.2",
"resolved": "https://registry.npmjs.org/firebase-functions/-/firebase-functions-7.3.2.tgz",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

⚠️ Duplicate firebase-functions Versions in Dependency Tree\n\nHaving multiple versions of firebase-functions (root at 7.3.3-rc.3 and nested at 7.3.2 under @firebaseextensions/firestore-bigquery-change-tracker) can lead to severe runtime issues. firebase-functions relies on global/singleton state for trigger registration and configuration; having duplicate instances of the module at runtime often causes silent deployment failures or initialization crashes (e.g., duplicate app initialization errors).\n\n#### Why this happens:\nUnder standard semver rules, the pre-release version 7.3.3-rc.3 does not satisfy the stable range ^7.3.0 required by @firebaseextensions/firestore-bigquery-change-tracker. As a result, npm resolves and installs a nested stable version (7.3.2), bypassing the deduplication process.\n\n#### Recommendation:\nConsider using a stable version of firebase-functions (e.g., ^7.3.2) in package.json to allow proper deduplication, or ensure that the override strictly forces a single version without causing nested duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants