Conversation
Adds the Notes entries for divergences that have no kit equivalent to restore: the kit- resource-name prefix, the missing billingRequired declaration, the missing deploy-time status surface, and validation moving from the install prompt to deploy time. Closes #3035
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation across several kit READMEs to detail platform-level differences between Firebase Extensions and the new kits. Key updates explain the new kit- resource prefix, the absence of billing declarations, the shift of status reporting to function logs, and the transition of configuration validation to deploy time. The feedback suggests a minor phrasing improvement in the main README to enhance readability regarding resource reuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writes the Notes entries for the accepted divergences in #3035, the ones with no kit equivalent to restore. Four are platform-level, so they go in
kits/README.mdunder "Migrating from an extension" rather than being repeated in every kit; the per-kit specifics go in the kit that has them.Changes
kits/README.md: new "Differences that apply to every kit" section covering theext-tokit-resource-name prefix, the missingbillingRequireddeclaration, the missing deploy-time status surface, and validation moving from the install prompt to deploy time.firestore-bigquery-export: note thatinitBigQuerySync/setupBigQuerySynconly report to logs, where the extension's install and update hooks set the instance's processing state.firestore-incremental-capture: note the same loss forrunInitialSetupandonFirestoreBackupInit.firestore-translate-text: note that the extension's backfill status counts went with the backfill.firestore-genai-chatbot: note thatvalidateRequiredEnvVars()is gone, that onlyPROJECT_IDstill has anything to check, and that the rest is enforced by the CLI at deploy.No entry added for
NODE_PATHtoRTDB_NODE_PATHor theext-tokit-topic rename:rtdb-limit-child-nodes,delete-user-dataandbigquery-firestore-exportalready document those.firestore-vector-searchalready notes its missing backfill progress reporting.Two corrections to the ledger's list while writing these.
storage-resize-imagesis not affected by the status surface: its foursetProcessingStatecalls are commented out (functions/src/index.ts:213-278).firestore-incremental-captureis affected and was not listed (5 calls infunctions/src/tasks/).billingRequired: trueis declared by 11 of the 13 predecessor extensions, not justfirestore-translate-textandrtdb-limit-child-nodes;speech-to-textandfirestore-bundle-buildernever declared it.Docs only, no code change.
prettier --list-differentis clean.