Repository navigation
sample(auth): add Grid, Coffee Spark and Professional themes with dark mode to the full customization demo - #2545
Merged
Conversation
…o the full customization demo
…rom their light palettes
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a dynamic theme-switching feature to the full customization demo, adding 'Doggo', 'Grid', and 'Coffee Spark' themes. It refactors several screens and components to use theme-aware styles, shapes, and backgrounds. The review feedback focuses on performance and UI polish: reading SharedPreferences outside of composition to avoid blocking the main thread, removing redundant background drawing and transparent scrims to prevent unnecessary overdraw, and clipping the theme switcher's selectable items to ensure the click ripple matches their rounded shape.
…themed CTA colours throughout
demolaf
marked this pull request as draft
October 29, 2026 09:17
…layout to the full customization demo
…parent scrim, and clip the switcher ripple
demolaf
marked this pull request as ready for review
November 3, 2026 15:37
russellwheatley
requested changes
Nov 3, 2026
russellwheatley
left a comment
Member
There was a problem hiding this comment.
Looks good overall, just two things on the Professional email screens.
…ate-account link when sign-up isn't offered
russellwheatley
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Grid, Coffee Spark and Professional themes to the full customization demo, a switcher on every screen, and dark variants of all four.
Changes
Preview