Repository navigation
docs: correct the auth README and getting-started guide against the GA API surface - #2544
Conversation
There was a problem hiding this comment.
Code Review
This pull request centralizes the Android Lint configuration in the root build file, applying a uniform policy across all subprojects and removing redundant lint blocks from individual modules. It also refactors error handling and localization in the auth module, mapping specific Firebase Auth error codes to localized messages via AuthUIStringProvider, and improves session cleanup during sign-out. Additionally, ContinueUrlBuilder was refactored to use Uri for safer parameter appending, and numerous localized string resources were updated. The review feedback recommends ensuring the tools namespace is declared in all XML files using tools:ignore to prevent compilation errors, and suggests optimizing regex instantiation by extracting the pattern to a companion object constant.
a13ce0a to
f0883e5
Compare
russellwheatley
left a comment
There was a problem hiding this comment.
One change on the getting-started sign-in snippet. Everything else I checked against the source lines up 👍
Corrects the auth README and the getting-started guide against the 10.0.0 API surface.
Changes
AuthStatematches the source:abstractnotsealed, no data classes,Error.exceptiontypedException, plusreauthenticatedUid,isNotificationand theReauthenticationhierarchy.mfaConfigurationtoFirebaseAuthScreen, and Error Handling covers all 21AuthExceptionsubclasses with anelse, mapping the six email-link types to theirAuthUIStringProvidercopy.fui_<object>_<constant>naming rule, with the stability promise covering all ofFirebaseAuthTestTags. Sign Out documents the Google and Facebook session clearing.rememberAuthConfigurationnow remembering and thecreateAuthFlowexample launching once rather than on every recreation.@ComposableAPIs alongsideapplicationContextnow sit insetContent { }, where both resolve.Config.kt/gradle.properties, which still read10.0.0-beta05. Documented third-party versions are pinned to the ones 10.0.0 ships with.AuthExceptionmessages that read "You are are attempting...".AuthExceptiononce instead of on every call.Maintainer note: Fixes internal CPRN-605, Fixes internal CPRN-616, Refs internal CPRN-490