ci: bring :app and :e2eTest under the Android Lint gate - #2503
Open
demolaf wants to merge 51 commits into
Open
Conversation
…tion that owns it (#2454) * refactor(auth): let the phone screen own its verification loading state * fix(auth): read auth state per authUI instance when clearing loading on dispose
…lot (#2452) * feat(auth): reshape reauthContent into a ReauthContentState content slot * fix(auth): address reauth review findings and retain state across recreation * refactor(auth): make reauthentication a request-scoped state machine * fix(auth): keep a proved reauthentication alive when its operation signs out * fix(auth): tear down phone verification when a reauthentication attempt fails * test(auth): cover sign-out-during-retry and phone reauth failure end to end * test(auth): drop the flaky phone reauth e2e case
…lment (#2462) * test(auth): pin onComplete and factor refresh on successful MFA enrollment * test(auth): pin the SMS MFA enrollment route through send, verify and resend * test(auth): pin the missing TOTP secret guard and the resend's clean enroll
…slot's sheet chrome (#2476) * test(auth): cover the three recoveries that write a value through to the step they move to * test(auth): assert a custom reauth slot's email and phone steps stay inside the library sheet
…and a screen-scoped phase holder
… FirebaseAuthUI singleton
… a stale composition value
… of returning quietly
…ad of calling it arming
…tead of the shared state flow
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables Android Lint checks for the :app and :e2eTest modules, integrating them into the root lintAll task and updating the project documentation. It also resolves several lint warnings by extracting hardcoded strings, suppressing specific app link and unused resource warnings, and removing unused assets. The reviewer feedback recommends updating an outdated comment in build.gradle.kts and suggests centralizing the common lint configuration in the root build file to avoid duplication across modules.
demolaf
force-pushed
the
ci/gate-app-and-e2etest-on-lint
branch
2 times, most recently
from
September 9, 2026 14:14
c848fb3 to
9da36a1
Compare
demolaf
marked this pull request as draft
September 9, 2026 14:31
demolaf
marked this pull request as ready for review
September 10, 2026 07:14
demolaf
force-pushed
the
ci/gate-app-and-e2etest-on-lint
branch
from
September 10, 2026 07:45
9da36a1 to
9aa0fee
Compare
demolaf
changed the base branch from
ci/run-android-lint-in-the-build
to
version-10.0.0-beta05
September 12, 2026 11:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2498 added
lintAllbut deliberately left:appand:e2eTestout, since neither had ever declared alint { }block and so neither had a policy to gate against. This sets that policy and brings both in, so the task now covers all ten Android modules.:e2eTestwas already clean and is a pure ratchet;:appreported 30 errors underwarningsAsErrors.Most of those are real and fixed here. The score row in the database and firestore demos moves to a
demo_score_rowresource,MainActivityloses a label duplicating the application's, the Android Studio templatecolors.xmland two orphaned launcher vectors go, andfirebase_authconverts to lossless WebP at all five densities (52KB down to 25KB, checked by comparing decoded pixels rather than trusting the encoder flag). The remainder are suppressed with the reason recorded at each suppression site: the App Link host and thefacebook_*strings are indirections per-module lint cannot resolve, whileAndroidGradlePluginVersion,LogConditionalandMonochromeLauncherIconare policy calls for a demo app.KaptUsageInsteadOfKspis disabled rather than fixed. KSP resolves against Kotlin 2.4.10 andcom.github.bumptech.glide:ksp:5.0.7exists, but Glide's KSP processor does not generate theGlideAppclass kapt produces, so:appstops compiling. Migrating means rewritingStorageDemoActivityto plainGlide.with()and updatingstorage/README.mdand theFirebaseImageLoaderjavadoc, both of which are written aroundGlideApp. Tracked separately.Adding two more copies of the same block made the duplication worth removing, so the common
disableset and the three strictness flags now live in a shared policy in the rootbuild.gradle.kts, beside theallprojectscheckstyle block that already centralises the other repo-wide gate. Modules keep only their own disables, and strictness is no longer something a module can quietly drop the way:librarydid withabortOnError = false. Across the build files that is 112 lines out for 56 in.Supersedes #2500, closed by a branch rename.
Maintainer note: Fixes internal CPRN-433