feat: structured data for faq #545
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
therobrob
commented
Dec 26, 2025
therobrob
commented
- refactored expander-code
- split up faq markdown
- added faq in structured data
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
therobrob
commented
Dec 26, 2025
| "name": "{{ $item.Title }}", | ||
| "acceptedAnswer": { | ||
| "@type": "Answer", | ||
| "text": {{ $item.Content | jsonify | safeHTML }} |
Member
Author
There was a problem hiding this comment.
This line doesn't convince me, because the output is in the wrong format yet.
therobrob
commented
Dec 26, 2025
|
|
||
| {{ $faq := where $gi.Pages ".File.Dir" "==" "generalinformation/faq/" }} | ||
|
|
||
| {{ range sort $faq ".File.BaseFileName" }} |
Member
Author
There was a problem hiding this comment.
Is the sorting order relevant to us? If so, we could use the weight-property in the preface to force a specific order.
Maybe we should rename the md-Files to the question-names?
therobrob
commented
Dec 26, 2025
Comment on lines
+6
to
+9
| "title" $title | ||
| "type" $type | ||
| "name" $name | ||
| "content" .Inner |
Member
Author
There was a problem hiding this comment.
didn’t work with capital letters..
therobrob
added
content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.