refactor: Merge link partials #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MoritzWeber0
force-pushed
the
refactor/merge-link-partials
branch
from
fb9a8e8 to
c801f9a
Compare
therobrob
added
the
technical
therobrob
approved these changes
Dec 26, 2025
MoritzWeber0
added a commit
that referenced
this pull request
Dec 29, 2025
In #541 a feature was introduced that allows links to be referenced by their path. The implementation didn't consider relative URLs like the ones including a language prefix like `/en/news`. This commit fixes the behaviour to make those links working again.
therobrob
pushed a commit
that referenced
this pull request
Dec 29, 2025
In #541 a feature was introduced that allows links to be referenced by their path. The implementation didn't consider relative URLs like the ones including a language prefix like `/en/news`. This PR fixes the behavior to make those links working again. Also replace more links with the link partial for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where telephone and email links no longer worked. In addition, add an email / phone icon in front of the respective links.