fix: 로그인 화면 로고 로딩 개선 - #8
Merged
Merged
Conversation
로그인 페이지를 서버 컴포넌트로 바꿔 reason과 callbackUrl 쿼리를 서버에서 읽어 폼에 넘깁니다. 폼 훅에서 useSearchParams를 걷어내 로고와 입력칸이 첫 HTML에 포함되도록 했습니다. 로고는 Icon의 지연 로딩 대신 정적으로 가져와 별도 청크 요청을 없앴습니다. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
finditem-bot
Bot
added
🐞 bug
Jest Test Results370 tests 370 ✅ 17s ⏱️ Results for commit 2ced6e2. |
Playwright Test Results42 tests 42 ✅ 15s ⏱️ Results for commit 2ced6e2. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
관련 이슈
작업 내용
useSearchParams를 써서 폼 전체가 서버에서 그려지지 않았고, 로고는Icon의 지연 로딩으로 폼 JS가 실행된 뒤 별도 청크로 한 번 더 받아지고 있었습니다.reason과callbackUrl쿼리를 서버에서 읽어 폼에 넘깁니다. 이에 따라useLoginReasonToast와useAdminLoginForm은 값을 인자로 받습니다.useForm과FormProvider는 새 클라이언트 컴포넌트인AdminLoginFormProvider로 옮겼습니다.Icon대신@/assets/logo.svg를 정적으로 가져옵니다. 공통Icon컴포넌트는 변경하지 않았습니다.getSingleSearchParam유틸과 단위 테스트를 추가했습니다.참고 사항
체크리스트
🤖 Generated with Claude Code