Code Quality: Removed ISidebarItemModel 1

[0x5bfa]

Resolved / Related Issues

This is part of the phase 1 mentioned in #17970 (comment)

• Code Quality: Broader SidebarView control usage #15283

Steps used to test these changes

• Check if an item has an icon
• Check if an item has a text
• Check if an item has a tooltip
• Check if an item has a correct decorator (pin icon, or eject button, etc)

[marcelwgn]

Why are we no longer doing this?

[0x5bfa]

We are now using binding for icons, we cannot call CreateIconElement in XAML.

[marcelwgn]

No, why are we no longer setting the UIA property appropriately? Also just because something doesnt work in xaml doesnt mean we should just ignore what the code did before.

[0x5bfa]

Don't we set it in XAML today already?

Files/src/Files.App.Controls/Sidebar/SidebarStyles.xaml

Lines 114 to 124 in 01ddde9

	<!-- Icon -->
	<ContentPresenter
	x:Name="IconPresenter"
	Grid.Column="1"
	Width="16"
	Height="16"
	Margin="8,0,0,0"
	HorizontalAlignment="Center"
	VerticalAlignment="Center"
	AutomationProperties.AccessibilityView="Raw"
	Content="{Binding Icon, Mode=OneWay, RelativeSource={RelativeSource TemplatedParent}}" />

[marcelwgn]

AccessibilityView is not a transitive property so every element needs to set it themselves. Just setting it on the presenter does not exclude its children from showing up in the UIA tree