[codex] add Setapp macOS distribution flow#12
Draft
seblavoie wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated macOS Setapp distribution path for File Architect.
This introduces a separate Setapp build flavor, native Setapp entitlement bridge, Setapp-aware auth/updater/UI behavior, and a GitHub Actions job to build Setapp release artifacts without committing the Setapp SDK to the repo.
What Changed
Why
Setapp requires a separate macOS app flavor with its own bundle identifier, Setapp-managed activation, and no direct-sale licensing or updater flow in the shipped Setapp build.
Validation
pnpm vitest run src/features/auth/__tests__/setappLicenseFlow.test.tsxcargo build --manifest-path src-tauri/Cargo.toml --bin filearchitect-appwithVITE_IS_SETAPP=truescripts/build_setapp_macos.shlocally through compile, bundle, and signingRemaining Note
Local notarization still depends on valid Apple notarization credentials. The Setapp build path itself now reaches that final notarization step.