ruby: Replay worker history with existing retry queue - #97
Closed
yfang-figma wants to merge 5 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This is an alternative implementation of #96 that replays a retried worker reservation history through the existing
CI::Queue::Redis::Retryqueue.--retry-mode worker-historybehavior while preserving failure-only retries by default.Why
SimpleCov data is process-local. When a distributed worker is terminated, coverage for tests that passed before termination is lost, while the existing Ruby retry path selects only failed tests from that worker reservation log.
Ruby historically retried the complete worker log, and the Python implementation still does. Reusing the existing local retry queue restores that model as an opt-in mode without introducing a two-phase queue wrapper that must proxy the Redis worker interface.
Behavioral difference from #96
After reconstructing coverage, this implementation exits. It does not resume claiming work from the shared queue. This matches current failure-retry behavior and the Python whole-worker retry path. If shared-queue resumption is a required production scenario, #96 second phase remains the meaningful tradeoff.
Validation
test/ci/queue/redis_test.rbbundle exec rake build