Repository navigation
Fixes for nightly - #1287
Open
jhdark wants to merge 9 commits into
Open
Fixes for nightly#1287jhdark wants to merge 9 commits into
jhdark wants to merge 9 commits into
Conversation
DOLFINx 0.12 wraps IndexMap and MeshTags.topology in Python classes, passes dof markers rather than boundary conditions to the C++ matrix assembler, and drops the insert_diagonal binding. Unwrap the objects handed to C++ bindings and fall back to the existing calls on 0.10 and 0.11. Drop the assertion that the parent facet measure gives the wrong gradient on a tilted manifold: it now gives the right one, and the assertion tested DOLFINx rather than FESTIM. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
==========================================
+ Coverage 96.13% 96.16% +0.02%
==========================================
Files 57 57
Lines 5199 5211 +12
==========================================
+ Hits 4998 5011 +13
+ Misses 201 200 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@jorgensd do these changes look alright to you? Dont know if this is a bit pre-emptive? |
Collaborator
|
@jhdark have you had a look at https://scientificcomputing.github.io/fenicsx-compat/main/docs/choosing.html for making migration smoother? |
dolfinx.fem.compute_integration_domains takes the Python topology on every supported version, so the interface code no longer has to hand the C++ binding a C++ topology. MeshTags.topology is still the C++ object on 0.10 and 0.11, so add a meshtags_topology helper mirroring fenicsx-compat's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It takes the Python mesh topology on every supported DOLFINx version, so the C++ binding and its hand-unwrapped topology are not needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replaces the inline unwrapping of MeshTags.topology with the shared helper, and adds a test for the mismatched-mesh error it guards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
V.dofmap is the same on every supported DOLFINx version for a single cell type, so the dofmaps method-or-sequence fallback is not needed. Only the index map wrapper (DOLFINx PR #4496) still needs unwrapping for the C++ binding. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Version("0.12.0.dev0") style comparisons misfire on development builds, and
the returned type already says which form the dof map is in: one array on
DOLFINx 0.10, a list of arrays (one per cell type) on 0.11 and later.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOLFINx 0.12 wraps IndexMap and MeshTags.topology in Python classes, passes dof markers rather than boundary conditions to the C++ matrix assembler, and drops the insert_diagonal binding. Unwrap the objects handed to C++ bindings and fall back to the existing calls on 0.10 and 0.11.
Drop the assertion that the parent facet measure gives the wrong gradient on a tilted manifold: it now gives the right one, and the assertion tested DOLFINx rather than FESTIM.
Description
Summary
Related Issues
Motivation and Context
Type of Change
Testing
pytest)Code Quality Checklist
ruff format .)ruff check .)Documentation
Breaking Changes
Screenshots/Examples
Additional Notes