Skip to content

Exclude dance model FBX files from release packages#158

Merged
fernandotonon merged 2 commits intomasterfrom
fix/exclude-dance-models-from-package
Feb 25, 2026
Merged

Exclude dance model FBX files from release packages#158
fernandotonon merged 2 commits intomasterfrom
fix/exclude-dance-models-from-package

Conversation

@fernandotonon
Copy link
Owner

Summary

  • Exclude Twist Dance, Rumba Dancing, and Hip Hop Dancing FBX files (~65 MB combined) from release packages
  • Files remain in the repository for unit test use (MergeAnimationsCLI tests)
  • Reduces package size on all three platforms (Linux .deb, macOS bundle, Windows zip)

Changes

  • media/CMakeLists.txt: Added PATTERN ... EXCLUDE rules to the install(DIRECTORY ...) command
  • .github/workflows/deploy.yml: Added explicit rm / Remove-Item cleanup steps after media copy for Linux, macOS, and Windows packaging

Test plan

  • Verify unit tests still pass (dance models remain in media/models/ in the repo)
  • Verify packaged builds don't contain the dance FBX files
  • Verify ninja.mesh and robot.mesh (non-test models) are still included in packages

🤖 Generated with Claude Code

fernandotonon and others added 2 commits February 25, 2026 16:12
The Twist Dance, Rumba Dancing, and Hip Hop Dancing FBX files (~65 MB
combined) are only needed for unit tests. Exclude them from the CMake
install target and remove them from Linux .deb, macOS bundle, and
Windows zip packages to reduce package size.

The files remain in the repository for test use.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The centralWidget had acceptDrops=true in the .ui file, which caused it
to intercept drop events before they reached MainWindow. Remove that
property so only MainWindow handles drops.

Also replace the fragile manual URI parsing (off-by-one in prefix
removal, broken chop on macOS line endings) with QUrl::toLocalFile()
which correctly handles all platforms and URL encoding.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@fernandotonon fernandotonon merged commit 6de3c64 into master Feb 25, 2026
12 checks passed
@fernandotonon fernandotonon deleted the fix/exclude-dance-models-from-package branch February 25, 2026 20:50
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant