Add CLI merge-animations process-level tests#155
Merged
fernandotonon merged 3 commits intomasterfrom Feb 25, 2026
Merged
Conversation
- AnimationMerger: new class to merge skeletal animations from multiple entities into a single base entity with skeleton compatibility checking - GUI: toolbar button to merge animations of selected entities - CLI: merge-animations subcommand for batch processing from command line - MCP: merge_animations tool for AI agent integration - Tests: MCP merge_animations tool tests and updated tools list - Docs: new Animation Merging section, updated MCP tools list (25 tools), updated Skeleton & Animation feature card, footer year to 2026 - Version bump to 2.8.0 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 QProcess-based tests exercising the full merge-animations CLI pipeline: argument validation, missing files, single-file rejection, and successful end-to-end merge with output verification. Tests skip gracefully when binary or test data files are unavailable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fernandotonon
force-pushed
the
test/merge-animations-cli
branch
from
7a0f471 to
c8ee05f
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a0f471e76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…y, and CI linker error - Verify base file loaded before proceeding (P1: honor --base flag) - Fix CLI example in docs to use correct --base/--animations/--output flags - Use QDir::tempPath() instead of hardcoded /tmp for cross-platform tests - Add AnimationMerger.cpp/.h to tests/CMakeLists.txt to fix CI linker error Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QProcess-based tests for themerge-animationsCLI subcommand covering argument validation, missing/nonexistent files, single-file rejection, and a full end-to-end merge with output verificationHip Hop Dancing.fbxtest data file (Mixamo character, same skeleton as existingTwist Dance.fbx)Test plan
MergeAnimationsCLI.*tests pass locally🤖 Generated with Claude Code