Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fengmk2 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new) #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
catalog:
'@types/node': 'npm:@types/node@24.12.2'
vite: 'npm:@voidzero-dev/vite-plus-core@latest'
vite-plus: latest
vitest: 'npm:@voidzero-dev/vite-plus-test@latest'
vite: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633'
vite-plus: 'https://pkg.pr.new/voidzero-dev/vite-plus@1633'
vitest: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633'

nodeLinker: node-modules

Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@
"oxc-parser": "^0.126.0",
"prettier": "^3.8.3",
"typescript": "^6.0.3",
"vite-plus": "^0.1.18",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Critical Issue: Non-Reproducible Builds

The current yarn.lock file contains unresolved pkg.pr.new URLs with PR numbers (e.g., @1633) instead of being pinned to specific commit hashes. This can lead to non-reproducible builds, as the dependency can change if new commits are pushed to the PR branch.

To fix this and improve maintainability, it's recommended to use the catalog: protocol for dependencies defined in your .yarnrc.yml catalog. This is the idiomatic approach for Yarn Berry and can help ensure dependencies are correctly resolved and pinned.

Suggested change
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633",
"vite-plus": "catalog:vite-plus",

"vitest": "^4.1.4"
},
"resolutions": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
"vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633",
"vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633"
Comment on lines +45 to +46
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

High Severity: Non-Reproducible Builds in Resolutions

The resolutions field also uses URLs with PR numbers, which can lead to non-reproducible builds for the same reason mentioned in the comment on vite-plus. Since you are using Yarn Berry and have a catalog defined in .yarnrc.yml, you can leverage it here as well.

Using the catalog: protocol avoids duplicating URLs and should help in correctly pinning the vitest dependency to a commit hash in yarn.lock.

Suggested change
"vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633",
"vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633"
"vite": "catalog:vite",
"vitest": "catalog:vitest"

},
"packageManager": "yarn@4.13.0"
}
Loading
Loading