chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#4
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, including vite, vite-plus, and vitest, to use pre-release versions from pkg.pr.new and adds a pnpm-workspace.yaml configuration file. The reviewer recommended updating the pnpm.overrides in package.json to target the full package names rather than aliases to ensure consistent resolution of transitive dependencies and avoid potential runtime issues.
| "vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633", | ||
| "vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633" |
There was a problem hiding this comment.
The pnpm.overrides should target the actual package names (@voidzero-dev/vite-plus-core and @voidzero-dev/vite-plus-test) instead of the aliases (vite and vitest). This will ensure that all transitive dependencies resolve to the same pre-release version, preventing duplication in your lockfile and potential runtime issues.
| "vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633", | |
| "vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633" | |
| "@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633", | |
| "@voidzero-dev/vite-plus-test": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633" |
Summary
Bump
vite-plusand related@voidzero-dev/*packages to the pkg-pr-new prerelease for vite-plus PR #1633.Updated where applicable:
vite-plus→https://pkg.pr.new/voidzero-dev/vite-plus@1633vitealias →@voidzero-dev/vite-plus-corepkg-pr-new URLvitestalias →@voidzero-dev/vite-plus-testpkg-pr-new URLoverrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsAlso configured
minimum-release-agewith vite-plus /@voidzero-dev/*excluded for pnpm / bun / npm.Test plan