Add support for stream overrides in configurations#601
Add support for stream overrides in configurations#601sgallagher wants to merge 2 commits intofedora-modularity:mainfrom
Conversation
Fixes: fedora-modularity#599 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Signed-off-by: Libmodulemd CI <github-actions@github.com>
|
I reviewed this patch. I found these minor omissions which should be checked or implemented:
But I really don't like how it breaks modulemd_packager_v3_to_stream_v2() and modulemd_packager_v3_to_stream_v2_ext() (which you adjusted tests for): The patch changes stream as a side effect in copy_packager_v3_buildconfig_to_stream_v2(). As a result modulemd_packager_v3_to_stream_v2() will assume a stream override of the latest buildconfig as a stream. It breaks modulemd_packager_v3_to_stream_v2() in the opposite direction than it's already broken in regard of buildopts. modulemd_packager_v3_to_stream_v2() adopts the first buildopts. And now it adopts the latest stream. I understand that it stems from the ill-design of modulemd_packager_v3_to_stream_v2_ext() which produces a single modulemd-v2 object instead of a list the objects, an objects for each modulemd-packager-v3 buildconfig. I would swallow it as a necessary collateral damage. But I don't like that the damage is not in accord with buildopts. Could you please change the patch to:
And document handling of the stream override in these conversion functions? |
Fixes: #599
Signed-off-by: Stephen Gallagher sgallagh@redhat.com