Add SolidStart integration and refactor `fedify init` internals by 2chanhaeng · Pull Request #652 · fedify-dev/fedify

2chanhaeng · 2026-03-28T13:29:45Z

Summary

Add @fedify/solidstart package for SolidStart integration and overhaul
fedify init internals: centralize dependency versions, replace
runSubCommand with @david/dax, and improve test infrastructure.

Related issue

Changes

packages/solidstart: Add packages/solidstart/ providing fedifyMiddleware() for SolidStart's middleware system. (by @dodok8)
packages/init:
- Add SolidStart web framework option. (by @dodok8)
- Extract hardcoded third-party dependency versions and add scripts/update_init_deps.ts to auto-update dependency versions.
- Refactor code like replacing runSubCommand with @david/dax.
- Use port 0 binding from 10000 while mise test:init.
- Print skipped and failed cases with reasons and directories.
packages/express: Fix bug by replacing req.host with req.header("Host").
packages/astro: Fix bug by adding --no-install for non-Deno package managers.
docs: Add docs about SolidStart integration. (by @dodok8)
examples/solidstart: Add an example app using SolidStart integration. (by @dodok8)

Benefits

SolidStart users can integrate Fedify with a single middleware call. (by @dodok8)
Dependency versions for fedify init templates are now centralized
and auto-updatable, reducing manual maintenance.
Replacing runSubCommand with @david/dax simplifies subprocess
handling and removes custom error classes.
Dynamic port allocation in tests eliminates port conflicts when
running multiple test apps sequentially.

Additional notes

The Express bug fix (req.host → req.header("Host")) is
independent of SolidStart but was discovered during integration
testing.
This PR builds on dodok8's initial SolidStart work in Add @fedify/solidstart package for SolidStart integration #601.

gemini-code-assist

Code Review

This pull request introduces the @fedify/solidstart package for SolidStart integration, providing a new middleware, comprehensive documentation, and an example project. Significant refactoring was performed on the @fedify/init package to centralize dependency versions in JSON files and migrate command execution to the dax library. Feedback highlights the need to update CHANGES.md with missing bug fixes and proper contributor credit, ensure consistency in middleware implementation examples, and move hardcoded dependency versions in the new SolidStart integration logic to the centralized configuration.

CHANGES.md

examples/solidstart/src/middleware/index.ts

packages/init/src/webframeworks/solidstart.ts

codecov · 2026-03-28T13:38:36Z

Codecov Report

❌ Patch coverage is 14.87759% with 452 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
packages/init/src/test/server.ts	3.61%	160 Missing ⚠️
packages/init/src/test/port.ts	10.43%	103 Missing ⚠️
packages/init/src/webframeworks/solidstart.ts	12.90%	81 Missing ⚠️
packages/init/src/test/lookup.ts	32.14%	57 Missing ⚠️
packages/init/src/action/utils.ts	40.00%	12 Missing ⚠️
packages/init/src/webframeworks/hono.ts	8.33%	11 Missing ⚠️
packages/init/src/webframeworks/elysia.ts	9.09%	10 Missing ⚠️
packages/init/src/webframeworks/astro.ts	10.00%	9 Missing ⚠️
packages/init/src/webframeworks/express.ts	12.50%	7 Missing ⚠️
packages/init/src/lib.ts	75.00%	1 Missing ⚠️
... and 1 more

Files with missing lines	Coverage Δ
packages/init/src/const.ts	`100.00% <100.00%> (ø)`
packages/init/src/webframeworks/const.ts	`100.00% <100.00%> (ø)`
packages/init/src/webframeworks/mod.ts	`100.00% <100.00%> (ø)`
packages/init/src/lib.ts	`48.38% <75.00%> (ø)`
packages/init/src/webframeworks/next.ts	`23.40% <50.00%> (ø)`
packages/init/src/webframeworks/express.ts	`16.92% <12.50%> (ø)`
packages/init/src/webframeworks/astro.ts	`12.79% <10.00%> (ø)`
packages/init/src/webframeworks/elysia.ts	`13.41% <9.09%> (ø)`
packages/init/src/webframeworks/hono.ts	`15.85% <8.33%> (ø)`
packages/init/src/action/utils.ts	`54.71% <40.00%> (-8.92%)`	⬇️
... and 4 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Extract the Fedify middleware for SolidStart into a dedicated package (@fedify/solidstart), providing a fedifyMiddleware() helper that handles ActivityPub content negotiation with SolidStart's middleware system. Uses a WeakMap<Request, Response> internally for 406 response storage, so users don't need to declare App.RequestEventLocals. Update the example to use the new package instead of inline middleware. fedify-dev#476 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add a SolidStart section to docs/manual/integration.md with installation instructions, app.config.ts setup, and middleware usage example. Add @fedify/solidstart changelog entry under Version 2.1.0, and update packages/fedify/README.md with JSR link for the new package. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add SolidStart as a web framework option in the `fedify init` command, allowing users to scaffold new Fedify+SolidStart projects. All boilerplate files (app config, middleware, routes, entry points) are provided as templates since no suitable degit template exists for SolidStart. The lookup test skips the solidstart+deno combination because Deno's `links` feature does not populate `node_modules/`, which Vite (used by vinxi) requires for SSR module resolution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Deno import maps use exact string matching, so the base "@solidjs/start" entry does not resolve subpath specifiers like "@solidjs/start/config" or "@solidjs/start/server". This adds explicit mappings for all subpaths used by the generated template files and @fedify/solidstart. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Consolidate lookup-test-only exclusions into a single pattern-based rule table so framework-wide and combination-specific bans follow the same matching logic. This keeps the supported-option checks unchanged while making the temporary lookup exclusions easier to maintain. Add regression tests for lookup case parsing and wildcard-based filtering. Co-Authored-By: OpenAI Codex <noreply@openai.com>

dahlia · 2026-03-29T08:37:48Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3c746fd88

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/solidstart/src/index.ts

dahlia

This PR is trying to address three separate issues at once: SolidStart integration, the Express host-resolution fix, and the fedify init refactor/test changes. That makes review, testing, backporting, and potential rollback much harder than necessary.

For future work, please split unrelated changes into separate PRs, ideally one PR per issue or per coherent change set. Smaller PRs are much easier to review and merge safely.

This is especially important here because features and bug fixes may need different review, testing, and backport paths.

docs/manual/integration.md

packages/solidstart/src/index.ts

dahlia · 2026-03-29T09:01:38Z

packages/express/src/index.ts


 function fromERequest(req: ERequest): Request {
-  const url = `${req.protocol}://${req.host ?? req.header("Host")}${req.url}`;
+  const url = `${req.protocol}://${req.header("Host")}${req.url}`;


req.header("Host") always uses the raw Host header, so this breaks deployments that sit behind a reverse proxy and rely on Express's trust proxy handling. If a proxied request arrives with a public X-Forwarded-Host, Fedify will reconstruct the request URL with the proxy's internal host instead of the external origin, which can break actor URLs and request/signature matching for federation endpoints.

How about update version of Express to 5.x? In 5.x, req.host is redesigned to return the full host with port while respecting trust proxy and X-Forwarded-Host.

Hmm, okay. The existing code seems to already depend on Express 5.x… However, still it's worked with Express 4.x when there's no port number in the Host/X-Forwarded-Host, right? I think we should still support both Express 4.x and 5.x, with noticing that it won't work if you use Express 4.x behind the reverse proxy with some port number in the docs.

Fixed in e534dca!

packages/init/src/test/port.ts

2chanhaeng

This PR is trying to address three separate issues at once: SolidStart integration, the Express host-resolution fix, and the fedify init refactor/test changes. That makes review, testing, backporting, and potential rollback much harder than necessary.

For future work, please split unrelated changes into separate PRs, ideally one PR per issue or per coherent change set. Smaller PRs are much easier to review and merge safely.

This is especially important here because features and bug fixes may need different review, testing, and backport paths.

Yes, I agree. You're right. But as I was working, I kept finding more things to fix. "I'll just do this one thing", "Just one more thing", but then the commits got all tangled up so I strugged to figure out how to split it up for the PR. I'll be more careful next time.

packages/init/src/test/port.ts

docs/manual/integration.md

packages/solidstart/src/index.ts

issues-auto-labeler bot added component/build Build system and packaging component/cli CLI tools related component/federation Federation object related component/integration Web framework integration labels Mar 28, 2026

gemini-code-assist bot reviewed Mar 28, 2026

View reviewed changes

CHANGES.md Outdated Show resolved Hide resolved

examples/solidstart/src/middleware/index.ts Show resolved Hide resolved

packages/init/src/webframeworks/solidstart.ts Show resolved Hide resolved

2chanhaeng and others added 23 commits March 29, 2026 01:10

Merge fedify-dev#638 to 2.1.0

706a32b

Add update_init_deps

1b0b100

Replace runSubCommand with @david/dax

14e5905

Fix fedify-dev#591

61387ab

Add example solidstart

40df6cb

Fix elysia section

093e3d1

Format all file

4e307c1

Fix markdown formatting for hongdown

6a0fd18

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Remove unnecessary async from callbacks

5d2693b

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Print skipped or failed cases

0b65354

Fix express integration

83988ef

Fix error with astro-npm combo

7d7ca2d

Modularize lookup test code

39ab688

Format

b84075b

Fixed code and version

d24e824

Apply comments from fedify-dev#601

4bc90c8

Move SolidStart deps versions

eaa34c1

Fix changelog

996acf9

2chanhaeng force-pushed the main branch from 118943d to 996acf9 Compare March 29, 2026 01:22

2chanhaeng added 2 commits March 29, 2026 01:49

Lint

3bdb1c8

Fix SolidStart tsdown config

f3c746f

dahlia self-assigned this Mar 29, 2026

chatgpt-codex-connector bot reviewed Mar 29, 2026

View reviewed changes

packages/solidstart/src/index.ts Show resolved Hide resolved

dahlia requested changes Mar 29, 2026

View reviewed changes

2chanhaeng added 3 commits March 30, 2026 11:39

Bind port 0

3464f0e

Fix docs

669cd2f

Fix astro tsdown config

9d433b6

2chanhaeng commented Mar 30, 2026

View reviewed changes

Use req.host in @fedify/express

e534dca

Uh oh!

Conversation

2chanhaeng commented Mar 28, 2026

Summary

Related issue

Changes

Benefits

Additional notes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dahlia commented Mar 29, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

dahlia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dahlia Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

2chanhaeng Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

dahlia Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

2chanhaeng Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

2chanhaeng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Mar 28, 2026 •

edited

Loading