Separeted @fedify/fixture from @fedify/fedify

[2chanhaeng]

Summary

Separeted @fedify/fixture from @fedify/fedify.

Related Issue

• closes Separate testing in @fedify/fedify to @fedify/fixture #508

Changes

• packages/fedify/src/testing
• packages/fixture

Benefits

The contributors can now import modules that were previously only available internally in @fedify/fedify from @fedify/fixture.

Checklist

• Did you add a changelog entry to the CHANGES.md?
• Did you write some relevant docs about this change (if it's a new feature)?
• Did you write a regression test to reproduce the bug (if it's a bug fix)?
• Did you write some tests for this change (if it's a new feature)?
• Did you run deno task test-all on your machine?

Additional Notes

Include any other information, context, or considerations.

[gemini-code-assist]

Summary of Changes

Hello @2chanhaeng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the project's testing infrastructure by extracting shared testing utilities and data fixtures into a new, dedicated package named @fedify/fixture. This change enhances modularity, promotes code reuse across different packages within the monorepo, and streamlines the testing process by centralizing common test resources.

Highlights

• New Package Creation: The @fedify/fixture package has been created to house common testing utilities and fixtures, separating them from the core @fedify/fedify package.
• Improved Reusability: Testing modules and fixtures previously internal to @fedify/fedify are now publicly available through @fedify/fixture, allowing other packages and contributors to easily import and utilize them.
• Refactored Test Imports: Numerous test files across the fedify and redis packages have been updated to import testing utilities (like test, mockDocumentLoader, createTestTracerProvider) from the new @fedify/fixture package instead of local paths or node:test.
• Build System Integration: The monorepo's deno.json and pnpm-workspace.yaml files have been updated to include the new fixture package, and a dedicated build task for it has been added to ensure proper compilation during testing.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully separates the testing utilities into a new @fedify/fixture package, which is a great improvement for modularity. The changes are mostly correct and consistent across the codebase.

I've found one critical issue regarding a circular dependency introduced between @fedify/fedify and the new @fedify/fixture package. Please see my comment on packages/fedify/package.json.

Also, there's a small typo in the pull request title ("Separeted" should be "Separated").

Overall, this is a solid refactoring. Addressing the circular dependency will make it perfect.

[gemini-code-assist]

The @fedify/fixture package should be a devDependency, not a dependency. The fedify package should not have a production dependency on testing utilities.

Currently, @fedify/fixture has a peerDependency on @fedify/fedify, and this change introduces a dependency from @fedify/fedify back to @fedify/fixture, creating a circular dependency.

Please remove this line and add @fedify/fixture to the devDependencies section.

[codecov]

Codecov Report

❌ Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
packages/relay/src/base.ts	93.33%	1 Missing and 1 partial ⚠️
packages/fixture/src/docloader.ts	80.00%	1 Missing ⚠️
packages/relay/src/builder.ts	50.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
packages/fedify/src/testing/context.ts	75.75% <100.00%> (ø)
packages/fedify/src/testing/keys.ts	100.00% <100.00%> (ø)
packages/fedify/src/testing/mod.ts	100.00% <100.00%> (+67.11%)	⬆️
packages/fixture/src/mod.ts	100.00% <100.00%> (ø)
packages/fixture/src/otel.ts	73.33% <ø> (ø)
packages/relay/src/factory.ts	100.00% <ø> (ø)
packages/relay/src/litepub.ts	85.24% <100.00%> (-0.12%)	⬇️
packages/relay/src/mastodon.ts	68.05% <100.00%> (-0.44%)	⬇️
packages/relay/src/mod.ts	100.00% <ø> (ø)
packages/relay/src/types.ts	100.00% <100.00%> (+10.00%)	⬆️
... and 3 more

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.