-
-
Notifications
You must be signed in to change notification settings - Fork 135
Lower suppressed vocabulary failures below error level #933
Copy link
Copy link
Labels
component/vocabActivity Vocabulary relatedActivity Vocabulary relatedcomponent/vocab-toolsVocabulary code generation (@fedify/vocab-tools)Vocabulary code generation (@fedify/vocab-tools)difficulty/beginnerBeginner friendlyBeginner friendlygood first issueGood for newcomersGood for newcomers
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
component/vocabActivity Vocabulary relatedActivity Vocabulary relatedcomponent/vocab-toolsVocabulary code generation (@fedify/vocab-tools)Vocabulary code generation (@fedify/vocab-tools)difficulty/beginnerBeginner friendlyBeginner friendlygood first issueGood for newcomersGood for newcomers
Type
Fields
Priority
Low
Effort
Low
Summary
Generated vocabulary accessors log parsing and fetch failures at error level even when callers pass
suppressError: true. This turns expected rejection of malformed remote objects into application error-tracking events despite the accessor returningnullas requested.Observed behavior
In @fedify/vocab-tools/src/property.ts, both the document-loader catch and JSON-LD parsing catch call
getLogger(["fedify", "vocab"]).error(...)whenoptions.suppressErroris enabled, then returnnull.Hackers' Pub calls
Announce.getObject({ suppressError: true })for untrusted inbox input. A remote URL returned a document that was not an ActivityStreamsObject, so the accessor correctly returnednull, but its error log produced five Sentry events underGRAPHQL-42withTypeError: Expected an object of any type of: https://www.w3.org/ns/activitystreams#Object.Expected behavior
Failures intentionally absorbed by
suppressError: trueshould be logged below error level, probably warning or debug. Callers that omitsuppressErrorwould continue to receive the thrown exception, so genuinely unhandled failures would remain visible to error tracking.Production evidence
The affected Sentry issue is https://hackerspub.sentry.io/issues/GRAPHQL-42.