🛠️ Refactor: JobsEndpoint - Extract ListEndpoint (DRY/OCP) #649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
JobsEndpointandmixins.pyto enforce SOLID principles and remove duplication.Changes:
ListEndpointfromListGetEndpointinimednet/core/endpoint/mixins.py. This new class encapsulates list functionality and allows configuring the paginator class viaPAGINATOR_CLSandASYNC_PAGINATOR_CLSclass attributes.ListGetEndpointto inherit fromListEndpoint, maintaining backward compatibility for existing endpoints.JobsEndpointinimednet/endpoints/jobs.pyto inherit fromListEndpointandPathGetEndpointMixin. This removed the manual implementation oflistandasync_list, delegating toListEndpointwhile overriding the paginator class toJsonListPaginator.tests/conftest.pyto patchListEndpoint.PAGINATOR_CLSandASYNC_PAGINATOR_CLSinpaginator_factoryandasync_paginator_factoryfixtures, ensuring tests continue to mock paginators correctly.Verification:
reproduce_jobs.py) ensuringJobsEndpointstill works correctly for both list and get operations (sync and async).tests/unit/endpoints/test_list_get.pyand full test suite to ensure no regressions.PR created automatically by Jules for task 9819530189907088638 started by @fderuiter