refactor: move version_flags from deprecated s.xcconfig to s.pod_target_xcconfig#25
Open
naxey wants to merge 1 commit into
Open
refactor: move version_flags from deprecated s.xcconfig to s.pod_target_xcconfig#25naxey wants to merge 1 commit into
naxey wants to merge 1 commit into
Conversation
The version_flags define was set via `s.xcconfig` which only applies to the consumer (app target), not to the pod's own compilation. This caused `REACT_NATIVE_MINOR_VERSION` to be undefined (defaulting to 0) when compiling FastSquircle's .mm files, making the `#if < 81` guard compile the legacy code path on RN >= 0.82. Move the flag to `s.pod_target_xcconfig` so it reaches the pod's own build. Fixes fbeccaceci#24
Closed
3 tasks
naxey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the deprecated
s.xcconfigwiths.pod_target_xcconfigfor version_flags inFastSquircle.podspec.
s.xcconfig has been deprecated since CocoaPods 0.38 in favor of the explicit
pod_target_xcconfig/user_target_xcconfig split.Related: #24
Test plan