Skip to content

Fix Windows wheel build quoting, and stop it from blocking other platforms' releases - #792

Merged
wbarnha merged 2 commits into
masterfrom
claude/faust-issue-790-patch-inkd2h
Aug 23, 2026
Merged

Fix Windows wheel build quoting, and stop it from blocking other platforms' releases#792
wbarnha merged 2 commits into
masterfrom
claude/faust-issue-790-patch-inkd2h

Conversation

@wbarnha

@wbarnha wbarnha commented Aug 23, 2026

Copy link
Copy Markdown
Member

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

e9f102f (#762) changed [tool.cibuildwheel] before-build in pyproject.toml
from pip install Cython to pip install 'Cython>=3.1'. cibuildwheel runs
that command through the platform's native shell, and on windows-2022 that's
cmd.exe, which does not treat single quotes as a quoting character. The >
was therefore parsed as cmd's output-redirection operator: the command ran as
pip install 'Cython with stdout redirected to a file literally named
3.1', so Cython was never installed and the Windows wheel build failed —
confirmed against the actual failed run log (cibuildwheel: Command pip install 'Cython>=3.1' failed with code 1.).

Because publish needs build_wheels, and a matrix job only succeeds if
every leg does, that one Windows failure blocked the release for every
platform, so PyPI releases went missing entirely.

Two changes:

  1. Double-quote the Cython version spec instead of single-quoting it —
    double quotes are honored by both cmd.exe and bash/zsh, so the command
    is quoted correctly on every platform cibuildwheel builds on here.
  2. Drop windows-2022 from the build_wheels matrix, so a future
    Windows-specific failure can no longer block releases for the other
    platforms. It can be re-added once Windows wheel builds have proven
    stable again.

Fixes #790

Test plan

  • python3 -c "import tomllib; tomllib.load(open('pyproject.toml','rb'))"pyproject.toml parses
  • python3 -c "import yaml; yaml.safe_load(open('.github/workflows/python-package.yml'))" — workflow YAML parses
  • CI passes on this PR (lint, tests, free-threading, wheel/sdist builds where applicable)

Generated by Claude Code

claude added 2 commits August 23, 2026 06:26
…re-build

cibuildwheel runs before-build through the native shell, which on
windows-2022 is cmd.exe. cmd.exe does not treat single quotes as a quoting
character, so `pip install 'Cython>=3.1'` left the `>` exposed as cmd's
output-redirection operator: the command ran as `pip install 'Cython` with
stdout redirected to a file named `3.1'`, installing nothing and failing the
whole build matrix (no fail-fast), which blocked every PyPI release.

Double quotes are honored by both cmd.exe and bash/zsh, so quote the spec
with those instead.

Fixes #790

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TzUaDNbLSKGwTF8iWTMkPF
publish needs build_wheels, and a matrix job only succeeds if every leg
does -- so a single broken Windows build blocks the release for every
platform, not just Windows (this is what happened in #790). Remove
windows-2022 from build_wheels' os list so releases can go out on the
other platforms independent of Windows wheel status.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (181b184) to head (3bb79ee).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #792   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files         110      110           
  Lines       11789    11789           
  Branches     1281     1281           
=======================================
  Hits        11342    11342           
  Misses        350      350           
  Partials       97       97           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wbarnha
wbarnha merged commit b3b4939 into master Aug 23, 2026
56 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows builds fail, causing missing PyPI releases

2 participants