feat: Robotics mcap インポートパイプライン追加#278
Open
rikunosuke wants to merge 5 commits into
Open
Conversation
- import-pipeline 系エンドポイントを data-lake/robotics/ 配下に変更 - signed-url レスポンスを dict 形式 (url キー) に対応 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
signed-url レスポンスを dict で扱うよう変更したため、str は不要 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yo-tak
requested changes
Jun 22, 2026
yo-tak
left a comment
yo-tak
left a comment
Contributor
There was a problem hiding this comment.
今回、非同期処理なのでこのAPI実行直後はインポート処理は終わってないと思いますが、進捗状況取得APIのようなものはないですよね？
そういったAPIがないのは単純に未開発なので良いと思いますが、進捗の確認方法（直接画面から確認かなと思います）は README.md あたりに記載した方が良いかと！
|
|
||
| Import an mcap zip file into an existing robotics task. | ||
|
|
||
| This method starts an import pipeline, uploads the zip file via a signed URL, and triggers the batch import. |
Contributor
There was a problem hiding this comment.
大した事項ではないんですが、このAPIを使うユーザーにとってimport pipelineやsigned URLの存在って重要でしょうか？
ユーザーが意識することではないのであれば、そこは省いても良いかなと（むしろ書いてあるとそのURL使ってなんかやる必要あるんだっけ？となってしまいそう）思います。
むしろ、この処理が同期なのか非同期なのかを明記した方が良いかなと思います。triggers the batch importで察することはできるかもしれませんが、そのbatch importを待って result が返ってくるのかどうかは分からないので。
内部実装の signed URL / pipeline の記述を削除し、処理が非同期である ことと import 履歴画面で状態を確認する旨を追記 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
yo-tak
requested changes
Jun 22, 2026
yo-tak
left a comment
yo-tak
left a comment
Contributor
There was a problem hiding this comment.
修正済みの文章良いと思います、ありがとうございます！
もう一箇所だけ対応お願いします 🙏
| @@ -0,0 +1,19 @@ | |||
| """ | |||
| Import an mcap zip file into an existing FastLabel robotics task. | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Robotics 向けの mcap zip ファイルインポート機能を追加します。
変更内容
import_robotics_mcap(project, task_id, file_path)をClientに追加.zip拡張子以外はFastLabelInvalidExceptionを送出_start_pipeline/_upload_zip_with_signed_url/_trigger_batch_importを追加data-lake/robotics/配下に変更urlキー）に対応Api.get_requestの戻り値型にstrを追加テスト
🤖 Generated with Claude Code