chore: upgrade connect-redis v9.x#347
Conversation
| import { createClient } from 'redis' | ||
| import { expect } from 'tstyche' | ||
| import fastifySession, { type CookieOptions, MemoryStore, type SessionStore } from '..' | ||
| import fastifySession, { |
There was a problem hiding this comment.
I think this PR should focus on upgrading the connect-redis package and removing unnecessary formatting changes.
There was a problem hiding this comment.
I think this PR should focus on upgrading the connect-redis package and removing unnecessary formatting changes.
If I need to make any changes let me know
There was a problem hiding this comment.
Revert unrelated lint changes plz, you can open new PRs if necessary for certain plugins.
I just made this change on core:
fastify/fastify@d267263
There was a problem hiding this comment.
The changes made are solely for the update to connect-redis-v9; everyone has their own configurations in their editors or IDEs. Before committing, I always run npm run lint.
There was a problem hiding this comment.
The changes made are solely for the update to connect-redis-v9;
Nope.
everyone has their own configurations in their editors or IDEs.
If your IDE mess with the current stylistics changes, it's your responsability to fix it before pushing.
I always run npm run lint.
Our current linting config doesn't enforce some stylistic choices, so your changes are not reverted by the linter.
But it creates noise in the PR review, it's ok because this one is small but in general this is a feedback you'll receive any time you add unrelated stylistic changes (I had the same in the past).
There was a problem hiding this comment.
Okay, I'll check. In the editor, I have two vertical lines showing 80 and 120. If I remember correctly, I locked it to 80 columns. I'm sure that's why it shifted some of the lines. 😆
3 participants
Proposal:
close #346
connect-redisfrom v8.x to v9.x ( https://github.com/tj/connect-redis/releases/tag/v9.0.0 )redisdependency instead ofioredis, because thev9.xversion ofconnect-redisno longer supportsioredisNote: