refactor: replace glob dependency with custom glob using node:fs#587
Closed
oldregime wants to merge 3 commits into
Closed
refactor: replace glob dependency with custom glob using node:fs#587oldregime wants to merge 3 commits into
oldregime wants to merge 3 commits into
Conversation
Member
|
Duplicate of #571 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the external
globdependency to reduce the package footprint, resolving issue #551.Since Node's native
fs.promises.globhas some limitations (like not following symlinked directories and inconsistent globstar pattern behavior on certain Node versions), we implement a small, robust custom directory walker inlib/glob.jsthat mimics the expected interface.Changes:
lib/glob.jswith support forglobIgnorepattern-matching, dotfiles, and symlinks.index.jsto require./lib/globinstead ofgloband removed the dependency frompackage.json.proxyquiremock in the tests to stub./lib/globinstead ofglob, and added additional test cases to cover the callback/promise patterns and error cases of the custom glob utility to achieve 100% code coverage.